From: Anand Mohanadoss <anand108@gmail.com>
To: Andy Wingo <wingo@pobox.com>
Cc: 19180@debbugs.gnu.org, "Ludovic Courtès" <ludo@gnu.org>,
"Linas Vepstas" <linasvepstas@gmail.com>
Subject: bug#19180: guile bug#19180: vacuum_weak_hash_table error
Date: Wed, 22 Jun 2016 21:13:05 +0530 [thread overview]
Message-ID: <CAFNjtaAMN-COihcWMzs=-bUtR0poDhkdoCpgaULY2kq1nrAuXw@mail.gmail.com> (raw)
In-Reply-To: <87twgls26t.fsf@pobox.com>
[-- Attachment #1: Type: text/plain, Size: 1376 bytes --]
Hi Andy,
Thanks a lot for looking into this and your response! Any idea when we
will have a stable 2.2 release that we can move to given that 2.1 has been
out for a few months.
Thanks,
Anand
On Wed, Jun 22, 2016 at 8:25 PM, Andy Wingo <wingo@pobox.com> wrote:
> Hi :)
>
> On Mon 15 Dec 2014 07:36, Anand Mohanadoss <anand108@gmail.com> writes:
>
> > Here is what we changed in hashtab.c -
> >
> > 130a131
> >> size_t orig_len = len;
> > 137,138c138,144
> > < assert (removed <= len);
> > < len -= removed;
> > ---
> >> if (removed <= len)
> >> len -= removed;
> >> else
> >> {
> >> printf ("Vacuum weak hash table assert Table=%p len=%zi removed=%zi
> > orig_len=%zi n_items=%zi\n", table, len, removed, orig_len,
> > SCM_HASHTABLE_N_ITEMS (table));
> >> len = 0;
> >> }
> >
> > With this change, we got lines similar to the following printed
> > periodically -
> >
> > Vacuum weak hash table assert Table=0x9bdb840 len=0 removed=1
> > orig_len=2321 n_items=2321
>
> I guess printing a warning is not worse than crashing. I was unable to
> make this table work in a reliable way in 2.0 without rewriting it, so
> in 2.2 there's a new implementation with hopefully no bug in this
> regard.
>
> Ludovic what do you thing, should we just be sloppy in 2.0 and remove
> the assertion? I don't think it's fixable. The other option I see is
> to close as WONTFIX.
>
> Andy
>
[-- Attachment #2: Type: text/html, Size: 2069 bytes --]
next prev parent reply other threads:[~2016-06-22 15:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAHrUA3554+87CVKsW2OT+-roVeyK4sE+xyDPaGf4ar5fAWQ2+Q@mail.gmail.com>
2014-12-08 7:34 ` bug#19180: guile bug#19180: vacuum_weak_hash_table error Anand Mohanadoss
2014-12-08 9:34 ` Ludovic Courtès
2014-12-15 6:36 ` Anand Mohanadoss
2016-06-22 14:55 ` Andy Wingo
2016-06-22 15:43 ` Anand Mohanadoss [this message]
2016-06-22 21:11 ` Linas Vepstas
2016-06-22 21:33 ` Andy Wingo
2016-06-23 4:24 ` Anand Mohanadoss
2016-07-12 7:32 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAFNjtaAMN-COihcWMzs=-bUtR0poDhkdoCpgaULY2kq1nrAuXw@mail.gmail.com' \
--to=anand108@gmail.com \
--cc=19180@debbugs.gnu.org \
--cc=linasvepstas@gmail.com \
--cc=ludo@gnu.org \
--cc=wingo@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).