From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Anand Mohanadoss Newsgroups: gmane.lisp.guile.bugs Subject: bug#19180: guile bug#19180: vacuum_weak_hash_table error Date: Wed, 22 Jun 2016 21:13:05 +0530 Message-ID: References: <87k322bi46.fsf@gnu.org> <87twgls26t.fsf@pobox.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=001a113f63d627fe2b0535dfcb91 X-Trace: ger.gmane.org 1466610387 23772 80.91.229.3 (22 Jun 2016 15:46:27 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 22 Jun 2016 15:46:27 +0000 (UTC) Cc: 19180@debbugs.gnu.org, Ludovic =?UTF-8?Q?Court=C3=A8s?= , Linas Vepstas To: Andy Wingo Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Wed Jun 22 17:46:18 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bFkM5-0001Hw-Rd for guile-bugs@m.gmane.org; Wed, 22 Jun 2016 17:46:18 +0200 Original-Received: from localhost ([::1]:59216 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFkM5-00075a-1b for guile-bugs@m.gmane.org; Wed, 22 Jun 2016 11:46:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45973) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFkJx-0005BK-7K for bug-guile@gnu.org; Wed, 22 Jun 2016 11:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bFkJt-0000ol-VR for bug-guile@gnu.org; Wed, 22 Jun 2016 11:44:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39001) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bFkJt-0000of-S8 for bug-guile@gnu.org; Wed, 22 Jun 2016 11:44:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bFkJt-0005zH-L2 for bug-guile@gnu.org; Wed, 22 Jun 2016 11:44:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Anand Mohanadoss Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Wed, 22 Jun 2016 15:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 19180 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 19180-submit@debbugs.gnu.org id=B19180.146661019322951 (code B ref 19180); Wed, 22 Jun 2016 15:44:01 +0000 Original-Received: (at 19180) by debbugs.gnu.org; 22 Jun 2016 15:43:13 +0000 Original-Received: from localhost ([127.0.0.1]:51338 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFkJ7-0005y7-9P for submit@debbugs.gnu.org; Wed, 22 Jun 2016 11:43:13 -0400 Original-Received: from mail-it0-f54.google.com ([209.85.214.54]:37167) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bFkJ5-0005xu-F3 for 19180@debbugs.gnu.org; Wed, 22 Jun 2016 11:43:11 -0400 Original-Received: by mail-it0-f54.google.com with SMTP id f6so41795730ith.0 for <19180@debbugs.gnu.org>; Wed, 22 Jun 2016 08:43:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=gEa8mXSGHoPA04SWkQ/QJ1Hu6hlDwqbW5cgtW6ioVFM=; b=lMVN3VfY8JcNBa5/z/QsBixxSRgLR31ryTRljQYwblBT5DG/RlLMocy0QbGPQI0Epd Bo9bdnns7VhJlKHwaK8AEgyVz1qScCd+q4Ej+mKM1oHTOW3NEFZWO95UgaNHAgatshIM X6xpCcq383b5R4xuh/8ZuxIVt54zu0zQqa8OFmiSCrQHl6vLqGxI5HblEL80okeVCy5b wUp5zWAaWbBpacU9ZZH6cUXzYaoWFR2XweiUCkkPCVU33RoziPU4YGcjyW/VHsIk3bpQ WtIUVL++cmy2v37lnF/JFADp8tOJ8Py/jmHi4YadhGEL8ppXjYQTGMOcPSs1j0IZ0QoH pPtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=gEa8mXSGHoPA04SWkQ/QJ1Hu6hlDwqbW5cgtW6ioVFM=; b=I+QbLhWH/RW/M/YJdvpcssUzGD5z0P5dIv4r0kkAzS9TTPD3yxqqjSawkBqpceXUvb Cw0VtrjAgaKTDZ01Z+swrNCgvCQL0Tdmi/pAW5BySS8cgcLq47NproJ3ssl0LoyKKFpl SnLtzJR9ztkcAjlbJ/8pVIW+pAiAqMZH/eq/8ZzoCo9vSN3BWXFeaL9UcQo6AgXOag97 Em810cwTU+LYJy5m5ei12vfGZ9HopJ99Nhwnyt8h4SCmmebW7JF1UuEBWJJ58vcxo9A2 bNCaqFiOj0GM35SYX6j9ZdGshVwM3Tw82W0vhL7EpzhLvaUO7atNcPvpByWAs0olT/8d tHTA== X-Gm-Message-State: ALyK8tKclk2MroDNMkuAKVvYKb29pnczvAc2psecPqCv0AR7927CdS7e5fxqZr6ATgWRGdSygvdadwh0RsnL1g== X-Received: by 10.36.13.76 with SMTP id 73mr14780611itx.79.1466610185920; Wed, 22 Jun 2016 08:43:05 -0700 (PDT) Original-Received: by 10.107.154.68 with HTTP; Wed, 22 Jun 2016 08:43:05 -0700 (PDT) In-Reply-To: <87twgls26t.fsf@pobox.com> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8129 Archived-At: --001a113f63d627fe2b0535dfcb91 Content-Type: text/plain; charset=UTF-8 Hi Andy, Thanks a lot for looking into this and your response! Any idea when we will have a stable 2.2 release that we can move to given that 2.1 has been out for a few months. Thanks, Anand On Wed, Jun 22, 2016 at 8:25 PM, Andy Wingo wrote: > Hi :) > > On Mon 15 Dec 2014 07:36, Anand Mohanadoss writes: > > > Here is what we changed in hashtab.c - > > > > 130a131 > >> size_t orig_len = len; > > 137,138c138,144 > > < assert (removed <= len); > > < len -= removed; > > --- > >> if (removed <= len) > >> len -= removed; > >> else > >> { > >> printf ("Vacuum weak hash table assert Table=%p len=%zi removed=%zi > > orig_len=%zi n_items=%zi\n", table, len, removed, orig_len, > > SCM_HASHTABLE_N_ITEMS (table)); > >> len = 0; > >> } > > > > With this change, we got lines similar to the following printed > > periodically - > > > > Vacuum weak hash table assert Table=0x9bdb840 len=0 removed=1 > > orig_len=2321 n_items=2321 > > I guess printing a warning is not worse than crashing. I was unable to > make this table work in a reliable way in 2.0 without rewriting it, so > in 2.2 there's a new implementation with hopefully no bug in this > regard. > > Ludovic what do you thing, should we just be sloppy in 2.0 and remove > the assertion? I don't think it's fixable. The other option I see is > to close as WONTFIX. > > Andy > --001a113f63d627fe2b0535dfcb91 Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable
Hi Andy,

Thanks a lot for look= ing into this and your response!=C2=A0 Any idea when we will have a stable = 2.2 release that we can move to given that 2.1 has been out for a few month= s.

Thanks,
Anand
=
On Wed, Jun 22, 2016 at 8:25 PM, Andy Wingo = <= wingo@pobox.com> wrote:
Hi = :)

On Mon 15 Dec 2014 07:36, Anand Mohanadoss <anand108@gmail.com> writes:

> Here is what we changed in hashtab.c -
>
> 130a131
>> size_t orig_len =3D len;
> 137,138c138,144
> < assert (removed <=3D len);
> < len -=3D removed;
> ---
>> if (removed <=3D len)
>> len -=3D removed;
>> else
>> {
>> printf ("Vacuum weak hash table assert Table=3D%p len=3D%zi r= emoved=3D%zi
> orig_len=3D%zi n_items=3D%zi\n", table, len, removed, orig_len, > SCM_HASHTABLE_N_ITEMS (table));
>> len =3D 0;
>> }
>
> With this change, we got lines similar to the following printed
> periodically -
>
> Vacuum weak hash table assert Table=3D0x9bdb840 len=3D0 removed=3D1 > orig_len=3D2321 n_items=3D2321

I guess printing a warning is not worse than crashing.=C2=A0 I was unable t= o
make this table work in a reliable way in 2.0 without rewriting it, so
in 2.2 there's a new implementation with hopefully no bug in this
regard.

Ludovic what do you thing, should we just be sloppy in 2.0 and remove
the assertion?=C2=A0 I don't think it's fixable.=C2=A0 The other op= tion I see is
to close as WONTFIX.

Andy

--001a113f63d627fe2b0535dfcb91--