From: isaac lewis <isaac.b.lewis@gmail.com>
To: 32040@debbugs.gnu.org
Subject: bug#32040: Potential REPL Server Bug (with a Patch)
Date: Mon, 2 Jul 2018 12:21:02 -0400 [thread overview]
Message-ID: <CA+a_5cggyx0gcsdAyNN+_JdUpABHPD+bLRFPVVR=9G_5jA6MJg@mail.gmail.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 1727 bytes --]
Good afternoon,
I experienced some issues on both Debian and Fedora a while ago with
the REPL server module. After searching the bug database, I didn't
find any similar reports, so I decided to investigate the issues a bit
more and found that they appear to be caused by a non-idiomatic use of
dynamic-wind (that was likely the result of a typo). A patch is
given below.
Sincerely,
Isaac Lewis
From 6dedc1a6d64ecbf6f1c9a4e60a6ea4a46c5b55ff Mon Sep 17 00:00:00 2001
From: Isaac Lewis <isaac.b.lewis@gmail.com>
Date: Mon, 2 Jul 2018 11:37:27 -0400
Subject: [PATCH] Fix a bug in the REPL server.
---
module/system/repl/server.scm | 17 +++++++++--------
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/module/system/repl/server.scm b/module/system/repl/server.scm
index 725eb4e..f18441d 100644
--- a/module/system/repl/server.scm
+++ b/module/system/repl/server.scm
@@ -146,14 +146,15 @@
(dynamic-wind
(lambda () #f)
- (with-continuation-barrier
- (lambda ()
- (parameterize ((current-input-port client)
- (current-output-port client)
- (current-error-port client)
- (current-warning-port client))
- (with-fluids ((*repl-stack* '()))
- (start-repl)))))
+ (lambda ()
+ (with-continuation-barrier
+ (lambda ()
+ (parameterize ((current-input-port client)
+ (current-output-port client)
+ (current-error-port client)
+ (current-warning-port client))
+ (with-fluids ((*repl-stack* '()))
+ (start-repl))))))
(lambda () (close-socket! client))))
--
2.9.5
[-- Attachment #2: Type: text/html, Size: 2232 bytes --]
next reply other threads:[~2018-07-02 16:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 16:21 isaac lewis [this message]
2022-12-16 22:16 ` bug#32040: bug in repl/server.scm Matt Wette
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CA+a_5cggyx0gcsdAyNN+_JdUpABHPD+bLRFPVVR=9G_5jA6MJg@mail.gmail.com' \
--to=isaac.b.lewis@gmail.com \
--cc=32040@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).