From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: isaac lewis Newsgroups: gmane.lisp.guile.bugs Subject: bug#32040: Potential REPL Server Bug (with a Patch) Date: Mon, 2 Jul 2018 12:21:02 -0400 Message-ID: NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="0000000000007088e4057006952e" X-Trace: blaine.gmane.org 1530548411 9786 195.159.176.226 (2 Jul 2018 16:20:11 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 2 Jul 2018 16:20:11 +0000 (UTC) To: 32040@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Mon Jul 02 18:20:06 2018 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fa1YZ-0002M2-K4 for guile-bugs@m.gmane.org; Mon, 02 Jul 2018 18:20:03 +0200 Original-Received: from localhost ([::1]:34092 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa1af-0004NZ-2m for guile-bugs@m.gmane.org; Mon, 02 Jul 2018 12:22:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42307) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa1aZ-0004Lq-Bn for bug-guile@gnu.org; Mon, 02 Jul 2018 12:22:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa1aU-0006S7-E2 for bug-guile@gnu.org; Mon, 02 Jul 2018 12:22:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:35936) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fa1aU-0006S1-97 for bug-guile@gnu.org; Mon, 02 Jul 2018 12:22:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fa1aU-0007i6-0C for bug-guile@gnu.org; Mon, 02 Jul 2018 12:22:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: isaac lewis Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Mon, 02 Jul 2018 16:22:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 32040 X-GNU-PR-Package: guile X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-guile@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.153054847629582 (code B ref -1); Mon, 02 Jul 2018 16:22:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Jul 2018 16:21:16 +0000 Original-Received: from localhost ([127.0.0.1]:43833 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fa1Zk-0007h4-5Z for submit@debbugs.gnu.org; Mon, 02 Jul 2018 12:21:16 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51222) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1fa1Zh-0007gp-Um for submit@debbugs.gnu.org; Mon, 02 Jul 2018 12:21:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa1Zb-00069y-Tm for submit@debbugs.gnu.org; Mon, 02 Jul 2018 12:21:08 -0400 Original-Received: from lists.gnu.org ([2001:4830:134:3::11]:48015) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fa1Zb-00069t-PG for submit@debbugs.gnu.org; Mon, 02 Jul 2018 12:21:07 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42193) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fa1Za-0004Io-AJ for bug-guile@gnu.org; Mon, 02 Jul 2018 12:21:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fa1ZZ-00068u-7G for bug-guile@gnu.org; Mon, 02 Jul 2018 12:21:06 -0400 Original-Received: from mail-wr0-x242.google.com ([2a00:1450:400c:c0c::242]:37254) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fa1ZY-00068O-Qi for bug-guile@gnu.org; Mon, 02 Jul 2018 12:21:05 -0400 Original-Received: by mail-wr0-x242.google.com with SMTP id q10-v6so1408078wrd.4 for ; Mon, 02 Jul 2018 09:21:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=Yv213gsvJ7kk4M8DLPEKixUbNdUhgHcBye3QEDTdPcE=; b=Wyi90Byi3D6fI9iN5dvsq9YIZa8ZArGPqENvM7FH6AjrpHJkAWH5JbU+D1aH3ejA1v hhi4qmhmHBL9qzh+yGFP2GYt72eXH4UAvxNshUzT6TinSDDmqTX00XAHZewQ8FB3ZMf8 RJoNwbYSVg9JfLNqrG2IwG1rFALMqcR2cIlEDVjZbM8M5EKlz5uQYPGc71VcBqAfL+68 JypkLt4ZUTvPR8sQZ7hKoHlolgbrwA8gczHlsvZb0bz2aQRJ1Wny0lrTcVpyfFhG+0P4 Vso/Doeo45Nc2ZU1DXmZrFLB4uCYWtWhczjHT9DNRBdVyjZrEy8rd7g21GM+H1L1/bwd bYAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=Yv213gsvJ7kk4M8DLPEKixUbNdUhgHcBye3QEDTdPcE=; b=sj9KgfLxySjpnC6rEs/xWF/k927Pb7FZ43SeZUgzlhPM0zAvU7RgJpBmHYUIJJkqTT fyi4ASRSVRdzxrOZtu80XP1Nal55YmW1hVhKi/VQKA6bol5pvsOgOpbqPvxyJS2UbPgu EHwOft1zRdfkSX95Ng45SIKuNe54YTTO0XHfZLFJZPFYd9q135BjSA0QpyhwQjockTC9 DOcPZd6QSLFbmA5XCeOoy37ZRmUPhIdVK8lqjTQI1GZkD2U5rPGoKd+Cbcx9cWgm7L+f Y/tnSDkF+cPsid8sLlao7WfY/LamFkMZcW2rzkZAIG7egtFxuNaBoUAx7EH5BVigDynv YrEQ== X-Gm-Message-State: APt69E3z+nhIUYRu+8DTRU4sxgKdcqxsUNRwOc2eSAh+d42dl1vArM4p yolM/U1navwvUQHGNncb1EkF4845/YLO9LzOOxwZ2w== X-Google-Smtp-Source: AAOMgpdYh6Bqu3PkDM2kkKPvstB5Dvlcuw+3UKa9zom2+iq1x8ufHaYEfrixHbk9CRyagswXnGZNm05Ugb9MhhSrNjY= X-Received: by 2002:adf:bc03:: with SMTP id s3-v6mr5913966wrg.211.1530548462846; Mon, 02 Jul 2018 09:21:02 -0700 (PDT) Original-Received: by 2002:adf:a589:0:0:0:0:0 with HTTP; Mon, 2 Jul 2018 09:21:02 -0700 (PDT) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:9085 Archived-At: --0000000000007088e4057006952e Content-Type: text/plain; charset="UTF-8" Good afternoon, I experienced some issues on both Debian and Fedora a while ago with the REPL server module. After searching the bug database, I didn't find any similar reports, so I decided to investigate the issues a bit more and found that they appear to be caused by a non-idiomatic use of dynamic-wind (that was likely the result of a typo). A patch is given below. Sincerely, Isaac Lewis >From 6dedc1a6d64ecbf6f1c9a4e60a6ea4a46c5b55ff Mon Sep 17 00:00:00 2001 From: Isaac Lewis Date: Mon, 2 Jul 2018 11:37:27 -0400 Subject: [PATCH] Fix a bug in the REPL server. --- module/system/repl/server.scm | 17 +++++++++-------- 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/module/system/repl/server.scm b/module/system/repl/server.scm index 725eb4e..f18441d 100644 --- a/module/system/repl/server.scm +++ b/module/system/repl/server.scm @@ -146,14 +146,15 @@ (dynamic-wind (lambda () #f) - (with-continuation-barrier - (lambda () - (parameterize ((current-input-port client) - (current-output-port client) - (current-error-port client) - (current-warning-port client)) - (with-fluids ((*repl-stack* '())) - (start-repl))))) + (lambda () + (with-continuation-barrier + (lambda () + (parameterize ((current-input-port client) + (current-output-port client) + (current-error-port client) + (current-warning-port client)) + (with-fluids ((*repl-stack* '())) + (start-repl)))))) (lambda () (close-socket! client)))) -- 2.9.5 --0000000000007088e4057006952e Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: base64 PGRpdiBkaXI9Imx0ciI+R29vZCBhZnRlcm5vb24sPGJyPjxicj5JIGV4cGVyaWVuY2VkIHNvbWUg aXNzdWVzIG9uIGJvdGggRGViaWFuIGFuZCBGZWRvcmEgYSB3aGlsZSBhZ28gd2l0aDxicj50aGUg UkVQTCBzZXJ2ZXIgbW9kdWxlLsKgIEFmdGVyIHNlYXJjaGluZyB0aGUgYnVnIGRhdGFiYXNlLCBJ IGRpZG4mIzM5O3Q8YnI+ZmluZCBhbnkgc2ltaWxhciByZXBvcnRzLCBzbyBJIGRlY2lkZWQgdG8g aW52ZXN0aWdhdGUgdGhlIGlzc3VlcyBhIGJpdDxicj5tb3JlIGFuZCBmb3VuZCB0aGF0IHRoZXkg YXBwZWFyIHRvIGJlIGNhdXNlZCBieSBhIG5vbi1pZGlvbWF0aWMgdXNlIG9mPGJyPmR5bmFtaWMt d2luZCAodGhhdCB3YXMgbGlrZWx5IHRoZSByZXN1bHQgb2YgYSB0eXBvKS7CoCBBIHBhdGNoIGlz PGJyPmdpdmVuIGJlbG93Ljxicj48YnI+U2luY2VyZWx5LDxicj48YnI+SXNhYWMgTGV3aXM8YnI+ PGJyPkZyb20gNmRlZGMxYTZkNjRlY2JmNmYxYzlhNGU2MGE2ZWE0YTQ2YzViNTVmZiBNb24gU2Vw IDE3IDAwOjAwOjAwIDIwMDE8YnI+RnJvbTogSXNhYWMgTGV3aXMgJmx0OzxhIGhyZWY9Im1haWx0 bzppc2FhYy5iLmxld2lzQGdtYWlsLmNvbSI+aXNhYWMuYi5sZXdpc0BnbWFpbC5jb208L2E+Jmd0 Ozxicj5EYXRlOiBNb24sIDIgSnVsIDIwMTggMTE6Mzc6MjcgLTA0MDA8YnI+U3ViamVjdDogW1BB VENIXSBGaXggYSBidWcgaW4gdGhlIFJFUEwgc2VydmVyLjxicj48YnI+LS0tPGJyPsKgbW9kdWxl L3N5c3RlbS9yZXBsL3NlcnZlci5zY20gfCAxNyArKysrKysrKystLS0tLS0tLTxicj7CoDEgZmls ZSBjaGFuZ2VkLCA5IGluc2VydGlvbnMoKyksIDggZGVsZXRpb25zKC0pPGJyPjxicj5kaWZmIC0t Z2l0IGEvbW9kdWxlL3N5c3RlbS9yZXBsL3NlcnZlci5zY20gYi9tb2R1bGUvc3lzdGVtL3JlcGwv c2VydmVyLnNjbTxicj5pbmRleCA3MjVlYjRlLi5mMTg0NDFkIDEwMDY0NDxicj4tLS0gYS9tb2R1 bGUvc3lzdGVtL3JlcGwvc2VydmVyLnNjbTxicj4rKysgYi9tb2R1bGUvc3lzdGVtL3JlcGwvc2Vy dmVyLnNjbTxicj5AQCAtMTQ2LDE0ICsxNDYsMTUgQEA8YnI+wqA8YnI+wqDCoCAoZHluYW1pYy13 aW5kPGJyPsKgwqDCoMKgIChsYW1iZGEgKCkgI2YpPGJyPi3CoMKgwqAgKHdpdGgtY29udGludWF0 aW9uLWJhcnJpZXI8YnI+LcKgwqDCoMKgIChsYW1iZGEgKCk8YnI+LcKgwqDCoMKgwqDCoCAocGFy YW1ldGVyaXplICgoY3VycmVudC1pbnB1dC1wb3J0IGNsaWVudCk8YnI+LcKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoY3VycmVudC1vdXRwdXQtcG9ydCBjbGllbnQp PGJyPi3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGN1cnJlbnQt ZXJyb3ItcG9ydCBjbGllbnQpPGJyPi3CoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqAgKGN1cnJlbnQtd2FybmluZy1wb3J0IGNsaWVudCkpPGJyPi3CoMKgwqDCoMKgwqDC oMKgICh3aXRoLWZsdWlkcyAoKCpyZXBsLXN0YWNrKiAmIzM5OygpKSk8YnI+LcKgwqDCoMKgwqDC oMKgwqDCoMKgIChzdGFydC1yZXBsKSkpKSk8YnI+K8KgwqDCoCAobGFtYmRhICgpPGJyPivCoMKg wqDCoMKgICh3aXRoLWNvbnRpbnVhdGlvbi1iYXJyaWVyPGJyPivCoMKgwqDCoMKgwqAgKGxhbWJk YSAoKTxicj4rwqDCoMKgwqDCoMKgwqDCoCAocGFyYW1ldGVyaXplICgoY3VycmVudC1pbnB1dC1w b3J0IGNsaWVudCk8YnI+K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqAgKGN1cnJlbnQtb3V0cHV0LXBvcnQgY2xpZW50KTxicj4rwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoCAoY3VycmVudC1lcnJvci1wb3J0IGNsaWVudCk8 YnI+K8KgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAgKGN1cnJl bnQtd2FybmluZy1wb3J0IGNsaWVudCkpPGJyPivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKg wqDCoMKgwqDCoMKgwqDCoCAod2l0aC1mbHVpZHMgKCgqcmVwbC1zdGFjayogJiMzOTsoKSkpPGJy PivCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC oMKgwqDCoMKgwqDCoMKgIChzdGFydC1yZXBsKSkpKSkpPGJyPsKgwqDCoMKgIChsYW1iZGEgKCkg KGNsb3NlLXNvY2tldCEgY2xpZW50KSkpKTxicj7CoDxicj7CoAw8YnI+LS0gPGJyPjIuOS41PGJy PjwvZGl2Pg0K --0000000000007088e4057006952e--