unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* bug#25492: floating point bug in 2.1.6
@ 2017-01-20  9:40 Daniel Llorens
       [not found] ` <handler.25492.B.148490524224084.ack@debbugs.gnu.org>
  0 siblings, 1 reply; 3+ messages in thread
From: Daniel Llorens @ 2017-01-20  9:40 UTC (permalink / raw)
  To: 25492


See below.

The bug happens after commit 35a90592501ebde7e7ddbf2486ca9d315e317d09, ‘Add unboxed floating point comparison instructions.’


> ./meta/guile 
GNU Guile 2.1.6
Copyright (C) 1995-2016 Free Software Foundation, Inc.

Guile comes with ABSOLUTELY NO WARRANTY; for details type `,show w'.
This program is free software, and you are welcome to redistribute it
under certain conditions; type `,show c' for details.

Enter `,help' for help.
scheme@(guile-user)> (define x 0.0)
scheme@(guile-user)> (< x 1.0)
$1 = #t
scheme@(guile-user)> (< x 0.9)
$2 = #f







^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#25492: [patch] floating point bug in 2.1.6
       [not found] ` <handler.25492.B.148490524224084.ack@debbugs.gnu.org>
@ 2017-02-07 11:26   ` Daniel Llorens
  2017-02-07 11:45   ` bug#25492: closing Daniel Llorens
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Llorens @ 2017-02-07 11:26 UTC (permalink / raw)
  To: 25492


It's a trivial patch. I don't know how to test it though.


From a0028723da283d39e5ab4e43f8934506a917498b Mon Sep 17 00:00:00 2001
From: Daniel Llorens <daniel.llorens@bluewin.ch>
Date: Tue, 7 Feb 2017 12:14:15 +0100
Subject: [PATCH] Fix bug #25492

* libguile/vm-engine.c (BR_F64_ARITHMETIC): Fix type.
---
 libguile/vm-engine.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libguile/vm-engine.c b/libguile/vm-engine.c
index 6848406..c9a9cec 100644
--- a/libguile/vm-engine.c
+++ b/libguile/vm-engine.c
@@ -361,7 +361,7 @@
 #define BR_F64_ARITHMETIC(crel)                                         \
   {                                                                     \
     scm_t_uint32 a, b;                                                  \
-    scm_t_uint64 x, y;                                                  \
+    double x, y;                                                        \
     UNPACK_24 (op, a);                                                  \
     UNPACK_24 (ip[1], b);                                               \
     x = SP_REF_F64 (a);                                                 \
-- 
2.10.1








^ permalink raw reply related	[flat|nested] 3+ messages in thread

* bug#25492: closing
       [not found] ` <handler.25492.B.148490524224084.ack@debbugs.gnu.org>
  2017-02-07 11:26   ` bug#25492: [patch] " Daniel Llorens
@ 2017-02-07 11:45   ` Daniel Llorens
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Llorens @ 2017-02-07 11:45 UTC (permalink / raw)
  To: 25492-close


Fixed in a0028723da283d39e5ab4e43f8934506a917498b.






^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2017-02-07 11:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-20  9:40 bug#25492: floating point bug in 2.1.6 Daniel Llorens
     [not found] ` <handler.25492.B.148490524224084.ack@debbugs.gnu.org>
2017-02-07 11:26   ` bug#25492: [patch] " Daniel Llorens
2017-02-07 11:45   ` bug#25492: closing Daniel Llorens

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).