From: Andy Wingo <wingo@pobox.com>
To: Daniel Llorens <daniel.llorens@bluewin.ch>
Cc: 21147@debbugs.gnu.org
Subject: bug#21147: readline history is stifled early so (readline-set! history-length nn) has no effect
Date: Fri, 24 Jun 2016 10:23:17 +0200 [thread overview]
Message-ID: <87ziqbgfm2.fsf@pobox.com> (raw)
In-Reply-To: <A5963D3C-2541-402F-8EAD-F3D13D5381A2@bluewin.ch> (Daniel Llorens's message of "Tue, 28 Jul 2015 10:06:06 +0200")
On Tue 28 Jul 2015 10:06, Daniel Llorens <daniel.llorens@bluewin.ch> writes:
> The default history-length is 200. When one imports (ice-9 readline),
> history is stifled to this value, so it doesn't matter if you set
> history-length to a larger value later on. I'm surprised that this has
> gone unnoticed up to now, since 200 is really small. I may be missing
> something...
>
> The patch changes scm_readline_options() so that history is only
> stiffled when the options are actually set. This is rather clumsy
> since it means that if one doesn't set the options, history will never
> be stifled.
>
> An alternative would be to add an optional readline-options argument
> to activate-readline. That way one would be able to increase
> history-length before the first time history is stifled, and otherwise
> things would work as they do now.
Thanks for the patch! Well why not. It's not perfect but it's an
improvement. Thanks for giving this a poke; applied to master.
Andy
next prev parent reply other threads:[~2016-06-24 8:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-28 8:06 bug#21147: readline history is stifled early so (readline-set! history-length nn) has no effect Daniel Llorens
2016-06-24 8:23 ` Andy Wingo [this message]
2016-06-24 8:23 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ziqbgfm2.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=21147@debbugs.gnu.org \
--cc=daniel.llorens@bluewin.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).