From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#21147: readline history is stifled early so (readline-set! history-length nn) has no effect Date: Fri, 24 Jun 2016 10:23:17 +0200 Message-ID: <87ziqbgfm2.fsf@pobox.com> References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466757814 22141 80.91.229.3 (24 Jun 2016 08:43:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jun 2016 08:43:34 +0000 (UTC) Cc: 21147@debbugs.gnu.org To: Daniel Llorens Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Fri Jun 24 10:43:24 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bGMhr-0003gr-PJ for guile-bugs@m.gmane.org; Fri, 24 Jun 2016 10:43:19 +0200 Original-Received: from localhost ([::1]:41989 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGMhl-0005nH-RJ for guile-bugs@m.gmane.org; Fri, 24 Jun 2016 04:43:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:36799) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGMPI-0000R5-E7 for bug-guile@gnu.org; Fri, 24 Jun 2016 04:24:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGMPC-0004Vl-GK for bug-guile@gnu.org; Fri, 24 Jun 2016 04:24:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40998) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGMPC-0004Vh-9w for bug-guile@gnu.org; Fri, 24 Jun 2016 04:24:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bGMPC-0001nm-5c for bug-guile@gnu.org; Fri, 24 Jun 2016 04:24:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andy Wingo Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 24 Jun 2016 08:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21147 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 21147-submit@debbugs.gnu.org id=B21147.14667566106867 (code B ref 21147); Fri, 24 Jun 2016 08:24:02 +0000 Original-Received: (at 21147) by debbugs.gnu.org; 24 Jun 2016 08:23:30 +0000 Original-Received: from localhost ([127.0.0.1]:53332 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGMOg-0001mh-6z for submit@debbugs.gnu.org; Fri, 24 Jun 2016 04:23:30 -0400 Original-Received: from pb-sasl1.pobox.com ([64.147.108.66]:55025 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGMOe-0001ma-Po for 21147@debbugs.gnu.org; Fri, 24 Jun 2016 04:23:29 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id 86A6218E2B; Fri, 24 Jun 2016 04:23:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=8IIhkU7TLuZDXhXTjhit8f+Ynp0=; b=icdwPw wK6jO5P/m3Zr7lnV+C0T7HjsoMfvXJQXzRKw2J7kPJj5ayVn1rSJBxv/RW1Cwhr6 PELXXisbM3CmsoU3Okl/pR0N9XV1ex5S/m7uZoEi83buQChxNYb/PdpoIwJHx9AC vwm0XDVEhCtAW4pGR/e7Bn5Y3P+tVIpANjgek= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=WxLlAzgljYDJpEGBtbExJOnBmPwGIkFv ooaX32NF8weTPB0bhwCBvjOWBXbhCpIKICp3u7abjOM6Gw2CjQqLMk5IPjiEHoVv r71zJBWAwuTAeR6BoRQ+xAse4p21DoDEb3m8jLklD10gBkqokzONCARun6lsrZJg WbLw4dayazs= Original-Received: from pb-sasl1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id 66A4818E27; Fri, 24 Jun 2016 04:23:25 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id 8FC1718E23; Fri, 24 Jun 2016 04:23:24 -0400 (EDT) In-Reply-To: (Daniel Llorens's message of "Tue, 28 Jul 2015 10:06:06 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-Pobox-Relay-ID: EB8CDCAE-39E4-11E6-9D2E-C1836462E9F6-02397024!pb-sasl1.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8211 Archived-At: On Tue 28 Jul 2015 10:06, Daniel Llorens writes: > The default history-length is 200. When one imports (ice-9 readline), > history is stifled to this value, so it doesn't matter if you set > history-length to a larger value later on. I'm surprised that this has > gone unnoticed up to now, since 200 is really small. I may be missing > something... > > The patch changes scm_readline_options() so that history is only > stiffled when the options are actually set. This is rather clumsy > since it means that if one doesn't set the options, history will never > be stifled. > > An alternative would be to add an optional readline-options argument > to activate-readline. That way one would be able to increase > history-length before the first time history is stifled, and otherwise > things would work as they do now. Thanks for the patch! Well why not. It's not perfect but it's an improvement. Thanks for giving this a poke; applied to master. Andy