From: "Göran Weinholt" <goran@weinholt.se>
To: 14917@debbugs.gnu.org
Subject: bug#14917: Missing range check in fxcopy-bit can give SIGABRT
Date: Sat, 20 Jul 2013 08:57:29 +0200 [thread overview]
Message-ID: <87y59190rq.fsf@industria.weinholt.se> (raw)
[-- Attachment #1: Type: text/plain, Size: 1139 bytes --]
Hello schemers,
the fxcopy-bit procedure from (rnrs) is missing some range checks. It
can return a non-fixnum:
scheme@(guile-user)> (import (rnrs))
scheme@(guile-user)> (fxcopy-bit 0 (fixnum-width) 1)
$1 = 9223372036854775808
It can also crash the guile process, which is somewhat surprising for a
fixnum procedure:
scheme@(guile-user)> (import (rnrs))
scheme@(guile-user)> (fxcopy-bit 0 100000000000 0)
FATAL: memory error in realloc
Aborted
Here's an alternative error message:
scheme@(guile-user)> (import (rnrs))
scheme@(guile-user)> (fxcopy-bit 0 1000000000000 0)
gmp: overflow in mpz type
Aborted
Other implementations of fxcopy-bit usually check that the third
argument is 0 or 1, but I'm not sure that is required.
There's also a bitwise-copy-bit procedure that is similary affected.
Tested with Guile 2.0.9.40-824b-dirty on an amd64 system.
Regards,
--
Göran Weinholt <goran@weinholt.se>
"Mr. Crane, please remember you're not required to answer any of
Lt. Tragg's questions. As a matter of fact, don't even discuss the
weather with him, he can be very persuasive." -- Perry Mason
[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]
next reply other threads:[~2013-07-20 6:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-20 6:57 Göran Weinholt [this message]
2016-06-21 7:35 ` bug#14917: Missing range check in fxcopy-bit can give SIGABRT Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y59190rq.fsf@industria.weinholt.se \
--to=goran@weinholt.se \
--cc=14917@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).