From: Andy Wingo <wingo@pobox.com>
To: ludo@gnu.org (Ludovic Courtès)
Cc: 12827-done@debbugs.gnu.org, Daniel Hartwig <mandyke@gmail.com>
Subject: bug#12827: [PATCH] Tweak web modules, support relative URIs
Date: Sun, 21 May 2017 14:05:41 +0200 [thread overview]
Message-ID: <87y3tqtnxm.fsf@pobox.com> (raw)
In-Reply-To: <877fdiad7u.fsf@gnu.org> ("Ludovic Courtès"'s message of "Tue, 21 Jun 2016 15:22:29 +0200")
On Tue 21 Jun 2016 15:22, ludo@gnu.org (Ludovic Courtès) writes:
> Andy Wingo <wingo@pobox.com> skribis:
>
>> I would like to apply this patch, to master at least. Any objections?
>> We need documentation for the new exports, is the only missing thing.
>
> On a quick glance that looks good. My only concern would be
> incompatibilities; for instance, the ‘content-location’ can now be an
> object that doesn’t pass ‘uri?’, IIUC. Not sure how much of a problem
> that is.
I have applied this patch with some modifications and added docs.
Notably, the behavior of uri? is unchanged relative to master (though
there's a deprecation note; see NEWS) and string->uri keeps its old
behavior of not throwing exceptions. I also removed the "absolute-uri?"
stuff because it was unused and it seems silly to reserve that useful
name in that way -- RFC 3986 defines "absolute uri" simply as being a
URI without a fragment. Weird definition.
Thank you for the patch, Daniel, and thanks to Ludo and Mark for working
through this bug.
Andy
prev parent reply other threads:[~2017-05-21 12:05 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAN3veRcJ4EMJ53vWSRG0HXfwdXbhUmdvUu8EuLfVV7abjZEt1Q@mail.gmail.com>
2013-02-24 10:45 ` bug#12827: [PATCH] Tweak web modules, support relative URIs Mark H Weaver
[not found] ` <87vc9i6ld2.fsf@tines.lan>
2013-02-24 12:31 ` Daniel Hartwig
2013-02-24 19:55 ` Mark H Weaver
2013-03-13 11:05 ` Andy Wingo
2013-03-16 14:25 ` Daniel Hartwig
2013-03-20 10:20 ` Andy Wingo
2016-06-20 19:52 ` Andy Wingo
2016-06-21 13:22 ` Ludovic Courtès
2017-05-21 12:05 ` Andy Wingo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3tqtnxm.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=12827-done@debbugs.gnu.org \
--cc=ludo@gnu.org \
--cc=mandyke@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).