From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#12827: [PATCH] Tweak web modules, support relative URIs Date: Sun, 21 May 2017 14:05:41 +0200 Message-ID: <87y3tqtnxm.fsf@pobox.com> References: <87vc9i6ld2.fsf@tines.lan> <87a9q7impu.fsf@pobox.com> <874m8n8won.fsf@pobox.com> <877fdiad7u.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1495368379 18438 195.159.176.226 (21 May 2017 12:06:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 21 May 2017 12:06:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) Cc: 12827-done@debbugs.gnu.org, Daniel Hartwig To: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Sun May 21 14:06:14 2017 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCPci-0004fO-H9 for guile-bugs@m.gmane.org; Sun, 21 May 2017 14:06:12 +0200 Original-Received: from localhost ([::1]:37787 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCPck-000175-Us for guile-bugs@m.gmane.org; Sun, 21 May 2017 08:06:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59501) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dCPcc-00015a-Lb for bug-guile@gnu.org; Sun, 21 May 2017 08:06:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dCPcY-00031l-N3 for bug-guile@gnu.org; Sun, 21 May 2017 08:06:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:55101) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dCPcY-00031a-Io for bug-guile@gnu.org; Sun, 21 May 2017 08:06:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dCPcY-00061y-5H for bug-guile@gnu.org; Sun, 21 May 2017 08:06:02 -0400 Resent-From: Andy Wingo Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Sun, 21 May 2017 12:06:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 12827 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Mail-Followup-To: 12827@debbugs.gnu.org, wingo@pobox.com, ludo@gnu.org Original-Received: via spool by 12827-done@debbugs.gnu.org id=D12827.149536835323161 (code D ref 12827); Sun, 21 May 2017 12:06:01 +0000 Original-Received: (at 12827-done) by debbugs.gnu.org; 21 May 2017 12:05:53 +0000 Original-Received: from localhost ([127.0.0.1]:57778 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCPcO-00061V-QT for submit@debbugs.gnu.org; Sun, 21 May 2017 08:05:52 -0400 Original-Received: from pb-sasl2.pobox.com ([64.147.108.67]:60570 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dCPcN-00061O-SC for 12827-done@debbugs.gnu.org; Sun, 21 May 2017 08:05:52 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 659106AF90; Sun, 21 May 2017 08:05:50 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=WU6RtbWXmEmm rG/qEnS0RsarUVM=; b=V6xbihDUoQguPFyNG0yiiFqIuZ+XR+iMyCwJRxRyREpq uFzUa5GwXAP9/dtK22mb5xsyoTJ23c+uaJ2hFQNuEeS+4DYWSVsq0nrZbx+A1zWW koVIzhXQI5xaI8NkU+8BuOX0yiZ4tTMDd5DXuMkCLVkgqrEbVeH2dAE3+FHs8a8= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=lgIyXK Qwx8Ic9pbug5c4MD60yKBmMwgUnZIj6qEfvTKpCqEZs+V0cmeT9Z1HFwogWYMu9w muQ3u4xnDOGOHUco0YbWvt4d0O5Ey+zVyeYRab5m0zc/os8cZJRaNAO4fVSfBe9B CPEVwaagFYTkx2U63xnZPtpSgduCiICUXHUZ8= Original-Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id 5EC896AF8F; Sun, 21 May 2017 08:05:50 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id 4FD866AF8E; Sun, 21 May 2017 08:05:49 -0400 (EDT) In-Reply-To: <877fdiad7u.fsf@gnu.org> ("Ludovic =?UTF-8?Q?Court=C3=A8s?="'s message of "Tue, 21 Jun 2016 15:22:29 +0200") X-Pobox-Relay-ID: D45F5730-3E1D-11E7-B6A7-384B894C8D7C-02397024!pb-sasl2.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8810 Archived-At: On Tue 21 Jun 2016 15:22, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Andy Wingo skribis: > >> I would like to apply this patch, to master at least. Any objections? >> We need documentation for the new exports, is the only missing thing. > > On a quick glance that looks good. My only concern would be > incompatibilities; for instance, the =E2=80=98content-location=E2=80=99 c= an now be an > object that doesn=E2=80=99t pass =E2=80=98uri?=E2=80=99, IIUC. Not sure = how much of a problem > that is. I have applied this patch with some modifications and added docs. Notably, the behavior of uri? is unchanged relative to master (though there's a deprecation note; see NEWS) and string->uri keeps its old behavior of not throwing exceptions. I also removed the "absolute-uri?" stuff because it was unused and it seems silly to reserve that useful name in that way -- RFC 3986 defines "absolute uri" simply as being a URI without a fragment. Weird definition. Thank you for the patch, Daniel, and thanks to Ludo and Mark for working through this bug. Andy