From: "Ludovic Courtès" <ludovic.courtes@inria.fr>
To: Andy Wingo <wingo@igalia.com>
Cc: 38388@debbugs.gnu.org
Subject: bug#38388: [2.9.5] Inaccurate source location info for unbound variables
Date: Thu, 28 Nov 2019 09:20:58 +0100 [thread overview]
Message-ID: <87y2w0za1h.fsf@inria.fr> (raw)
In-Reply-To: <87o8wxabm3.fsf@igalia.com> (Andy Wingo's message of "Wed, 27 Nov 2019 10:53:56 +0100")
Hello!
Andy Wingo <wingo@igalia.com> skribis:
> On Tue 26 Nov 2019 16:20, Ludovic Courtès <ludovic.courtes@inria.fr> writes:
>
>> I have a test that runs ‘guix system build’ on this file:
>>
>> (use-modules (gnu)) ; 1
>> (use-service-modules networking) ; 2
>>
>> (operating-system ; 4
>> (host-name "antelope") ; 5
>> (timezone "Europe/Paris") ; 6
>> (locale "en_US.UTF-8") ; 7
>>
>> (bootloader (GRUB-config (target "/dev/sdX"))) ; 9
>> (file-systems (cons (file-system
>> (device (file-system-label "root"))
>> (mount-point "/")
>> (type "ext4"))
>> %base-file-systems)))
>>
>> Here, ‘GRUB-config’ is unbound, and the test expects to see a stack
>> frame corresponding to line 9.
>>
>> However, the stack frame we get is for line 11, char 32, which
>> corresponds to (file-system-label "root").
>>
>> So it would seem that the IP-to-source-location mapping is not quite
>> working as expected.
>>
>> Thoughts?
>
> What version is this with?
The wrong location info is with 2.9.5. 2.2.x (and 2.0.x) work fine.
Any idea where I should poke for debugging?
> Unfortunately as you know, bare identifiers don't have good source
> location information. There are small improvements that can be made but
> larger improvments are gnarly. Could be this is a case for a small
> improvement though!
I know, that’s why this test checks a favorable case (symbol wrapped in
an sexp). So I agree this would be a welcome improvement, but I think
it’s unnecessary for the purposes of the use case above.
Thanks,
Ludo’.
next prev parent reply other threads:[~2019-11-28 8:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 15:20 bug#38388: [2.9.5] Inaccurate source location info for unbound variables Ludovic Courtès
2019-11-27 9:53 ` Andy Wingo
2019-11-28 8:20 ` Ludovic Courtès [this message]
2019-11-29 11:04 ` Andy Wingo
2020-03-07 16:06 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y2w0za1h.fsf@inria.fr \
--to=ludovic.courtes@inria.fr \
--cc=38388@debbugs.gnu.org \
--cc=wingo@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).