From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Newsgroups: gmane.lisp.guile.bugs Subject: bug#38388: [2.9.5] Inaccurate source location info for unbound variables Date: Thu, 28 Nov 2019 09:20:58 +0100 Message-ID: <87y2w0za1h.fsf@inria.fr> References: <8736ea64vg.fsf@inria.fr> <87o8wxabm3.fsf@igalia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="102829"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) Cc: 38388@debbugs.gnu.org To: Andy Wingo Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Thu Nov 28 09:31:10 2019 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iaFCg-000Qbv-9r for guile-bugs@m.gmane.org; Thu, 28 Nov 2019 09:31:10 +0100 Original-Received: from localhost ([::1]:46454 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaFCe-0005LF-PB for guile-bugs@m.gmane.org; Thu, 28 Nov 2019 03:31:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52600) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iaF3u-0004mE-P6 for bug-guile@gnu.org; Thu, 28 Nov 2019 03:22:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iaF3s-0000vq-N3 for bug-guile@gnu.org; Thu, 28 Nov 2019 03:22:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50611) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iaF3s-0000sO-J3 for bug-guile@gnu.org; Thu, 28 Nov 2019 03:22:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iaF3q-0002Wv-Fg for bug-guile@gnu.org; Thu, 28 Nov 2019 03:22:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 28 Nov 2019 08:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 38388 X-GNU-PR-Package: guile Original-Received: via spool by 38388-submit@debbugs.gnu.org id=B38388.15749292689654 (code B ref 38388); Thu, 28 Nov 2019 08:22:02 +0000 Original-Received: (at 38388) by debbugs.gnu.org; 28 Nov 2019 08:21:08 +0000 Original-Received: from localhost ([127.0.0.1]:56584 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaF2x-0002Vd-MX for submit@debbugs.gnu.org; Thu, 28 Nov 2019 03:21:07 -0500 Original-Received: from mail2-relais-roc.national.inria.fr ([192.134.164.83]:32908) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iaF2w-0002Ub-41 for 38388@debbugs.gnu.org; Thu, 28 Nov 2019 03:21:06 -0500 X-IronPort-AV: E=Sophos;i="5.69,252,1571695200"; d="scan'208";a="413898079" Original-Received: from unknown (HELO ribbon) ([193.50.110.248]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-GCM-SHA384; 28 Nov 2019 09:20:59 +0100 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 8 Frimaire an 228 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu In-Reply-To: <87o8wxabm3.fsf@igalia.com> (Andy Wingo's message of "Wed, 27 Nov 2019 10:53:56 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:9477 Archived-At: Hello! Andy Wingo skribis: > On Tue 26 Nov 2019 16:20, Ludovic Court=C3=A8s = writes: > >> I have a test that runs =E2=80=98guix system build=E2=80=99 on this file: >> >> (use-modules (gnu)) ; 1 >> (use-service-modules networking) ; 2 >> >> (operating-system ; 4 >> (host-name "antelope") ; 5 >> (timezone "Europe/Paris") ; 6 >> (locale "en_US.UTF-8") ; 7 >> >> (bootloader (GRUB-config (target "/dev/sdX"))) ; 9 >> (file-systems (cons (file-system >> (device (file-system-label "root")) >> (mount-point "/") >> (type "ext4")) >> %base-file-systems))) >> >> Here, =E2=80=98GRUB-config=E2=80=99 is unbound, and the test expects to = see a stack >> frame corresponding to line 9. >> >> However, the stack frame we get is for line 11, char 32, which >> corresponds to (file-system-label "root"). >> >> So it would seem that the IP-to-source-location mapping is not quite >> working as expected. >> >> Thoughts? > > What version is this with? The wrong location info is with 2.9.5. 2.2.x (and 2.0.x) work fine. Any idea where I should poke for debugging? > Unfortunately as you know, bare identifiers don't have good source > location information. There are small improvements that can be made but > larger improvments are gnarly. Could be this is a case for a small > improvement though! I know, that=E2=80=99s why this test checks a favorable case (symbol wrappe= d in an sexp). So I agree this would be a welcome improvement, but I think it=E2=80=99s unnecessary for the purposes of the use case above. Thanks, Ludo=E2=80=99.