bug#18065: guile hangs if strerror is called with invalid (non-int) argument

bug#18065: guile hangs if strerror is called with invalid (non-int) argument

[Glenn Michaels]

Calling strerror with a non-integer argument causes guile to hang.
e.g.:

(strerror 1.5)

It's a locking issue, which is solved by the following trivial patch:

--- a/libguile/error.c
+++ b/libguile/error.c
@@ -121,10 +121,12 @@ SCM_DEFINE (scm_strerror, "strerror", 1, 0, 0,
 #define FUNC_NAME s_scm_strerror
 {
   SCM ret;
+  int errnum;
   scm_dynwind_begin (0);
+  errnum = scm_to_int (err);
   scm_i_dynwind_pthread_mutex_lock (&scm_i_misc_mutex);
 
-  ret = scm_from_locale_string (strerror (scm_to_int (err)));
+  ret = scm_from_locale_string (strerror (errnum));
 
   scm_dynwind_end ();
   return ret;

bug#18065: guile hangs if strerror is called with invalid (non-int) argument

[Ian Price]

Your patch does solve this issue, but I'm not 100% why the problem
occurs in the first place, as the lock should have been unlocked when
the throw occurred.

If I catch the wrong type error explicitly, then there is no problem.

scheme@(guile-user)> (catch #t (lambda () (strerror 1.5)) list)
$1 = (wrong-type-arg #f "Wrong type (expecting ~A): ~S" ("exact integer" 1.5) (1.5))

My thinking is that the a pre-unwind handler in the repl tries to lock
the same mutex, but I haven't looked into this deeply enough.

-- 
Ian Price -- shift-reset.com

"Programming is like pinball. The reward for doing it well is
the opportunity to do it again" - from "The Wizardy Compiled"

bug#18065: guile hangs if strerror is called with invalid (non-int) argument

[Mark H Weaver]

Fixed in fda17c20a3d088fccab1671c8881bd217d83d5f6 on the stable-2.0
branch, which will become Guile 2.0.12.

     Thanks,
       Mark