From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: 10519@debbugs.gnu.org, "Niels Möller" <nisse@lysator.liu.se>,
"Torbjorn Granlund" <tg@gmplib.org>
Subject: bug#10519: guile and (mini-)gmp
Date: Sun, 22 Jul 2012 11:04:25 +0200 [thread overview]
Message-ID: <87txx0415y.fsf@gnu.org> (raw)
In-Reply-To: <87aa5o2bm2.fsf@netris.org> (Mark H. Weaver's message of "Mon, 16 Jan 2012 05:19:33 -0500")
Hi Mark!
Mark H Weaver <mhw@netris.org> skribis:
> nisse@lysator.liu.se (Niels Möller) writes:
>> 2. The next problem is maybe more a nuisance than a real problem. I'm
>> looking at scm_i_big2dbl, in numbers.c.
>>
>> I notice this code doesn't currently use mpz_get_d (comment says
>> that's because gmp-4.2 and earlier didn't do well-defined rounding).
[...]
> Don't worry about this. I have a patch set that (among other things)
> reimplements scm_i_big2dbl in a much more robust way, with proper
> rounding, and without using such low-level GMP accessors. I posted this
> patch set to guile-devel on 7 Oct, "[PATCH] Improvements to exact
> rationals et al". I will resubmit it soon.
Apparently this didn’t make it into the tree yet, right? Could you
resubmit it?
>> 3. Occcasional use of mpq functions (do_divide, scm_inexact_to_exact),
>> for conversion of fradctions to and from doubles. mini-gmp has no
>> mpq-functions (and it shouldn't have), so these calls have to either
>> be eliminated altogether, or be made conditional on HAVE_LIBGMP.
>>
>> For conversion double->fraction, mpq seems overkill: Just multiply by
>> a power of two to make the number an integer, to construct a fraction
>> p / 2^k, and then eliminate any common factors of two (if fractions
>> are required to be in some canonical form).
>
> Agreed. I can easily reimplement this to avoid the mpq functions, and
> will do so.
Nice. Could you look into it? :-)
Thanks!
Ludo’.
next prev parent reply other threads:[~2012-07-22 9:04 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 21:22 bug#10519: guile and (mini-)gmp Niels Möller
2012-01-16 10:19 ` Mark H Weaver
2012-01-16 14:06 ` Niels Möller
2012-01-16 19:21 ` Mark H Weaver
2012-01-28 9:49 ` Niels Möller
2012-01-28 10:10 ` Mark H Weaver
2012-07-22 9:04 ` Ludovic Courtès [this message]
2012-02-03 13:40 ` Andy Wingo
2012-02-03 19:56 ` Niels Möller
2012-02-03 20:01 ` Torbjorn Granlund
2012-02-04 22:46 ` Ludovic Courtès
2012-07-22 9:00 ` Ludovic Courtès
2012-07-22 23:17 ` Niels Möller
2012-08-10 21:51 ` Ludovic Courtès
2012-08-11 9:37 ` Niels Möller
2012-08-11 19:46 ` Ludovic Courtès
2012-08-11 21:50 ` Niels Möller
2012-08-11 22:48 ` Ludovic Courtès
2013-03-02 20:04 ` Andy Wingo
2013-03-02 20:58 ` Mark H Weaver
2013-03-05 19:09 ` Mark H Weaver
2013-03-18 0:01 ` Mark H Weaver
2013-03-18 9:19 ` Ludovic Courtès
2013-03-26 8:17 ` Niels Möller
2013-03-27 17:00 ` Mark H Weaver
2016-10-27 12:29 ` Niels Möller
2016-11-10 19:56 ` Andy Wingo
2013-03-02 21:45 ` Niels Möller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87txx0415y.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=10519@debbugs.gnu.org \
--cc=mhw@netris.org \
--cc=nisse@lysator.liu.se \
--cc=tg@gmplib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).