From: ludo@gnu.org (Ludovic Courtès)
To: nisse@lysator.liu.se (Niels Möller)
Cc: 10519@debbugs.gnu.org, Torbjorn Granlund <tg@gmplib.org>
Subject: bug#10519: guile and (mini-)gmp
Date: Fri, 10 Aug 2012 23:51:00 +0200 [thread overview]
Message-ID: <874noawh4r.fsf@gnu.org> (raw)
In-Reply-To: <nnipdfl71c.fsf@stalhein.lysator.liu.se> ("Niels \=\?iso-8859-1\?Q\?M\=F6ller\=22's\?\= message of "Mon, 23 Jul 2012 01:17:51 +0200")
Hi Niels,
nisse@lysator.liu.se (Niels Möller) skribis:
> ludo@gnu.org (Ludovic Courtès) writes:
>
>> Reviving the discussion, as we’ve been discussing this at the GHM, and
>> some people would really like to see it happen. :-)
>
> Great! Any summary of the discussion, for those of us who couldn't make
> it there?
Mostly a few people reaffirmed the need for this.
> I'm attaching a patch from I tree I have around, without reading it
> carefully. I'm not sure this is the latest version I worked with. Maybe
> it's of some use.
Yes, thanks. I just tried it, and here’s the status:
- numbers.c uses ‘GMP_NUMB_BITS’, which is lacking;
- it also still uses mpq’s, as Mark noted;
- random.c uses ‘mpz_realloc2’, also lacking.
>>> 1. The header file libguile.h. As far as I understand, this is a public
>>> header file and it's use of <gmp.h> means that the public guile ABI
>>> depends on gmp.
>>
>> The problem is that there’s a public API dealing with mpz_t:
>
> Exactly. To me, that seems like a potentially hairy problem to get
> right.
>
>> SCM_API void scm_to_mpz (SCM x, mpz_t rop);
>> SCM_API SCM scm_from_mpz (mpz_t rop);
>>
>> So, when mini-gmp is used, a <gmp.h> header should be installed as well,
>> say under <libguile/mini-gmp.h>. WDYT?
>
> Maybe it would make sense with a level of indirection. User's could
> include libguile/bignum.h, which would in turn include either mini-gmp.h
> or the real gmp.h, depending on how guile was configured.
Users are only supposed to include <libguile.h>; headers under
libguile/ aren’t meant to be included directly.
Currently including <libguile.h> pulls <gmp.h>. When mini-GMP is used
instead, then <libguile/mini-gmp.h> would be pulled instead,
transparently.
> Users may also need some way of figuring out if they need to link with
> -lgmp or not.
libguile-2.0.la and guile-2.0.pc would provide that info.
>>> Since mini-gmp is not binary compatible,
>>
>> I don’t think there’s a problem, because only mpz_t objects appear in
>> the API, and they’re pointers.
[...]
> Hmm, or if you're saying that the use of mpz_t in guile's public API is
> pointers only, that that might make things a little simpler. But things
> will still break badly if the user's code is linked with gmp and guile
> uses mini-gmp, or vice versa.
Exactly, that’s the only case where it would break, AFAICS. And it’s
probably an unlikely use case: users who want to use both GMP and Guile
surely have libguile linked against GMP.
>>> 4. mini-gmp has no mp_set_memory_functions.
>
> That's added now, with the subtle difference that mini-gmp doesn't pass
> a valid size for the old_size argument for the free and realloc
> functions. I don't think guile depends on that feature.
No, it doesn’t.
I’m slightly concerned about mini-gmp, though. It’s almost 5000 lines,
mostly copied from GMP AIUI, but with no way to synchronize. How do you
consider the maintenance cost of this?
I understand some people want this, and I’m happy you’re helping, but
the amount of work and duplication involved would definitely be a
showstopper for me if you and Mark weren’t helping.
Thanks,
Ludo’.
next prev parent reply other threads:[~2012-08-10 21:51 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-15 21:22 bug#10519: guile and (mini-)gmp Niels Möller
2012-01-16 10:19 ` Mark H Weaver
2012-01-16 14:06 ` Niels Möller
2012-01-16 19:21 ` Mark H Weaver
2012-01-28 9:49 ` Niels Möller
2012-01-28 10:10 ` Mark H Weaver
2012-07-22 9:04 ` Ludovic Courtès
2012-02-03 13:40 ` Andy Wingo
2012-02-03 19:56 ` Niels Möller
2012-02-03 20:01 ` Torbjorn Granlund
2012-02-04 22:46 ` Ludovic Courtès
2012-07-22 9:00 ` Ludovic Courtès
2012-07-22 23:17 ` Niels Möller
2012-08-10 21:51 ` Ludovic Courtès [this message]
2012-08-11 9:37 ` Niels Möller
2012-08-11 19:46 ` Ludovic Courtès
2012-08-11 21:50 ` Niels Möller
2012-08-11 22:48 ` Ludovic Courtès
2013-03-02 20:04 ` Andy Wingo
2013-03-02 20:58 ` Mark H Weaver
2013-03-05 19:09 ` Mark H Weaver
2013-03-18 0:01 ` Mark H Weaver
2013-03-18 9:19 ` Ludovic Courtès
2013-03-26 8:17 ` Niels Möller
2013-03-27 17:00 ` Mark H Weaver
2016-10-27 12:29 ` Niels Möller
2016-11-10 19:56 ` Andy Wingo
2013-03-02 21:45 ` Niels Möller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874noawh4r.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=10519@debbugs.gnu.org \
--cc=nisse@lysator.liu.se \
--cc=tg@gmplib.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).