* bug#23404: Infinite recursion in GOOPS in Guile 2.2
@ 2016-04-30 0:27 Christopher Allan Webber
2016-04-30 2:26 ` Christopher Allan Webber
2016-04-30 2:27 ` Christopher Allan Webber
0 siblings, 2 replies; 4+ messages in thread
From: Christopher Allan Webber @ 2016-04-30 0:27 UTC (permalink / raw)
To: 23404
Heya all,
So I've been building something with GOOPS, and I decided to try it out
with Guile 2.2. Unfortunately, I hit a pretty nasty bug. You can try
it yourself... the code is pretty short:
(use-modules (oop goops)
(srfi srfi-9))
(define-class <some-class> ())
(define-method (time-to-break (some-class <some-class>) not-a-class)
(display "We're never going home are we?\n"))
;; And now, call it
(time-to-break (make <some-class>) 1)
This will loop forever and *never* complete. Why?
Turns out this is why, from goops.scm:
(define (single-arity-cache-dispatch cache nargs cache-miss)
(match cache
(() cache-miss)
(((typev . cmethod) . cache)
(cond
((eqv? nargs (vector-length typev))
(let ((cache-miss (single-arity-cache-dispatch cache nargs cache-miss)))
I'm not sure what was supposed to happen (presumably the cache was
supposed to be narrowed down somehow), but what happens here is that
single-arity-cache-dispatch keeps calling single-arity-cache-dispatch
forever.
scheme@(guile-user) [1]> ,bt
In oop/goops.scm:
1437:41939 (cache-miss #<<hive> e8a1e0> #<<message> id: "5c787e65bbeb34b27ffd16eead286fc6:1" to: ("8394701db8…>)
1486:41938 (memoize-effective-method! _ _ _)
1466:131937 (recompute-generic-function-dispatch-procedure! #<<generic> hive-process-message (1)>)
1452:161936 (compute-generic-function-dispatch-procedure _)
1378:251935 (single-arity-cache-dispatch _ 2 _)
1378:251934 (single-arity-cache-dispatch _ 2 _)
1378:251933 (single-arity-cache-dispatch _ 2 _)
1378:251932 (single-arity-cache-dispatch _ 2 _)
1378:251931 (single-arity-cache-dispatch _ 2 _)
1378:251930 (single-arity-cache-dispatch _ 2 _)
1378:251929 (single-arity-cache-dispatch _ 2 _)
1378:251928 (single-arity-cache-dispatch _ 2 _)
1378:251927 (single-arity-cache-dispatch _ 2 _)
1378:251926 (single-arity-cache-dispatch _ 2 _)
1378:251925 (single-arity-cache-dispatch _ 2 _)
1378:251924 (single-arity-cache-dispatch _ 2 _)
... etc ...
(g?)Oops!
- Chris
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#23404: Infinite recursion in GOOPS in Guile 2.2
2016-04-30 0:27 bug#23404: Infinite recursion in GOOPS in Guile 2.2 Christopher Allan Webber
@ 2016-04-30 2:26 ` Christopher Allan Webber
2016-04-30 2:27 ` Christopher Allan Webber
1 sibling, 0 replies; 4+ messages in thread
From: Christopher Allan Webber @ 2016-04-30 2:26 UTC (permalink / raw)
To: 23404
It looks like my example was incomplete. It turns out loading and
passing in an srfi-9 record is critical to instantiating the bug.
Why? I'm not sure...
(use-modules (oop goops)
(srfi srfi-9))
(define-class <some-class> ())
(define-record-type <some-record>
(make-some-record foo)
some-record?
(foo some-record-foo))
(define-method (time-to-break (some-class <some-class>) not-a-class)
(display "We're never going home are we?\n"))
;; Now it'll break
(time-to-break (make <some-class>) (make-some-record 1))
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#23404: Infinite recursion in GOOPS in Guile 2.2
2016-04-30 0:27 bug#23404: Infinite recursion in GOOPS in Guile 2.2 Christopher Allan Webber
2016-04-30 2:26 ` Christopher Allan Webber
@ 2016-04-30 2:27 ` Christopher Allan Webber
2017-02-28 15:12 ` Andy Wingo
1 sibling, 1 reply; 4+ messages in thread
From: Christopher Allan Webber @ 2016-04-30 2:27 UTC (permalink / raw)
To: 23404
It looks like my example was incomplete. It turns out loading and
passing in an srfi-9 record is critical to instantiating the bug.
Why? I'm not sure...
(use-modules (oop goops)
(srfi srfi-9))
(define-class <some-class> ())
(define-record-type <some-record>
(make-some-record foo)
some-record?
(foo some-record-foo))
(define-method (time-to-break (some-class <some-class>) not-a-class)
(display "We're never going home are we?\n"))
;; Now it'll break
(time-to-break (make <some-class>) (make-some-record 1))
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#23404: Infinite recursion in GOOPS in Guile 2.2
2016-04-30 2:27 ` Christopher Allan Webber
@ 2017-02-28 15:12 ` Andy Wingo
0 siblings, 0 replies; 4+ messages in thread
From: Andy Wingo @ 2017-02-28 15:12 UTC (permalink / raw)
To: Christopher Allan Webber; +Cc: 23404-done
On Sat 30 Apr 2016 04:27, Christopher Allan Webber <cwebber@dustycloud.org> writes:
> It looks like my example was incomplete. It turns out loading and
> passing in an srfi-9 record is critical to instantiating the bug.
>
> Why? I'm not sure...
>
> (use-modules (oop goops)
> (srfi srfi-9))
> (define-class <some-class> ())
> (define-record-type <some-record>
> (make-some-record foo)
> some-record?
> (foo some-record-foo))
>
> (define-method (time-to-break (some-class <some-class>) not-a-class)
> (display "We're never going home are we?\n"))
>
> ;; Now it'll break
> (time-to-break (make <some-class>) (make-some-record 1))
This appears to be fixed, somehow (?). Please reopen if you can still
produce the bug.
Andy
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-02-28 15:12 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-04-30 0:27 bug#23404: Infinite recursion in GOOPS in Guile 2.2 Christopher Allan Webber
2016-04-30 2:26 ` Christopher Allan Webber
2016-04-30 2:27 ` Christopher Allan Webber
2017-02-28 15:12 ` Andy Wingo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).