unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* bug#10131: [patch] add $expt alias
@ 2011-11-24 22:25 Christian Persch
  2011-12-19  0:17 ` Ludovic Courtès
  0 siblings, 1 reply; 2+ messages in thread
From: Christian Persch @ 2011-11-24 22:25 UTC (permalink / raw)
  To: 10131

[-- Attachment #1: Type: text/plain, Size: 533 bytes --]

Hi;

commit 6fc4d0124d633d1b3ddc5af82967f23bd17556f8
Author: Andy Wingo <wingo@pobox.com>
Date:   Thu Sep 3 12:19:39 2009 +0200

That commit removed $expt completely without even adding a deprecated
alias (like commit ad79736c68a803a59814fbfc0cb4b092c2b4cddf did for the
other $foo functions). This removal caused a bug in aisleriot
[https://bugzilla.gnome.org/show_bug.cgi?id=649730] which was quite
hard to track down without a deprecation warning; so the attached patch
adds a deprecated alias that does warn.

Regards,
	Christian

[-- Attachment #2: p --]
[-- Type: application/octet-stream, Size: 1238 bytes --]

From b4bd7dbff748c6912d680e963fad3ed20a4efe12 Mon Sep 17 00:00:00 2001
From: Christian Persch <chpe@gnome.org>
Date: Thu, 24 Nov 2011 23:10:21 +0100
Subject: [PATCH] Add a deprecated alias for $expt

* module/ice-9/deprecated.scm: Add alias for $expt. $expt was removed
  in commit 6fc4d0124d633d1b3ddc5af82967f23bd17556f8 but no deprecated
  alias was added in ad79736c68a803a59814fbfc0cb4b092c2b4cddf like for
  all the other deprecated $sin, $cos, ... functions.
---
 module/ice-9/deprecated.scm |    5 +++++
 1 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/module/ice-9/deprecated.scm b/module/ice-9/deprecated.scm
index f4ae2e3..4628bab 100644
--- a/module/ice-9/deprecated.scm
+++ b/module/ice-9/deprecated.scm
@@ -26,6 +26,7 @@
             $sqrt
             $abs
             $exp
+            $expt
             $log
             $sin
             $cos
@@ -300,6 +301,10 @@
   (issue-deprecation-warning
    "`$exp' is deprecated.  Use `exp' instead.")
   (exp z))
+(define ($expt z1 z2)
+  (issue-deprecation-warning
+   "`$expt' is deprecated.  Use `expt' instead.")
+  (expt z1 z2))
 (define ($log z)
   (issue-deprecation-warning
    "`$log' is deprecated.  Use `log' instead.")
-- 
1.7.5.1.217.g4e3aa.dirty


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#10131: [patch] add $expt alias
  2011-11-24 22:25 bug#10131: [patch] add $expt alias Christian Persch
@ 2011-12-19  0:17 ` Ludovic Courtès
  0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2011-12-19  0:17 UTC (permalink / raw)
  To: Christian Persch; +Cc: 10131-done

Hi Christian,

Sorry for the late reply.

Christian Persch <chpe@gnome.org> skribis:

> From b4bd7dbff748c6912d680e963fad3ed20a4efe12 Mon Sep 17 00:00:00 2001
> From: Christian Persch <chpe@gnome.org>
> Date: Thu, 24 Nov 2011 23:10:21 +0100
> Subject: [PATCH] Add a deprecated alias for $expt
>
> * module/ice-9/deprecated.scm: Add alias for $expt. $expt was removed
>   in commit 6fc4d0124d633d1b3ddc5af82967f23bd17556f8 but no deprecated
>   alias was added in ad79736c68a803a59814fbfc0cb4b092c2b4cddf like for
>   all the other deprecated $sin, $cos, ... functions.
> ---
>  module/ice-9/deprecated.scm |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

Sorry for the inconvenience.  The patch is now applied and will be in
2.0.4.

Thanks!

Ludo’.





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-12-19  0:17 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-11-24 22:25 bug#10131: [patch] add $expt alias Christian Persch
2011-12-19  0:17 ` Ludovic Courtès

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).