From: Andy Wingo <wingo@pobox.com>
To: Zefram <zefram@fysh.org>
Cc: 26149-done@debbugs.gnu.org
Subject: bug#26149: SRFI-19 doc erroneously warns about Gregorian reform
Date: Tue, 25 Apr 2017 09:44:53 +0200 [thread overview]
Message-ID: <87r30hszgq.fsf@pobox.com> (raw)
In-Reply-To: <20170419161139.GA16454@fysh.org> (zefram@fysh.org's message of "Wed, 19 Apr 2017 17:11:39 +0100")
On Wed 19 Apr 2017 18:11, Zefram <zefram@fysh.org> writes:
> Andy Wingo wrote:
>>This makes sense to me, FWIW.
>
> Patch attached.
Thank you! Applied. I adapted the change log message to follow Guile
conventions; it was:
> From 444703940983d559935c4dd2a2c89d7888c67119 Mon Sep 17 00:00:00 2001
> From: Zefram <zefram@fysh.org>
> Date: Wed, 19 Apr 2017 17:08:30 +0100
> Subject: [PATCH] correct note about Gregorian reform in SRFI-19
>
> SRFI-19 specifies proleptic use of the Gregorian calendar, so it was
> incorrect of the documentation to describe the code as erroneous in
> doing so. Rewrite the caution more neutrally, and move it to the section
> about the "date" structure, where it seems most relevant.
As applied:
Correct note about Gregorian reform in SRFI-19
* doc/ref/srfi-modules.texi (SRFI-19): SRFI-19 specifies proleptic use
of the Gregorian calendar, so it was incorrect of the documentation to
describe the code as erroneous in doing so. Rewrite the caution more
neutrally, and move it to the section about the "date" structure, where
it seems most relevant.
Note capitalization of the summary line and an inclusion of the file and
section/function in the commit message. I know the file is redundant
but this is how we currently do it. If you use Emacs and Magit,
pressing "C" (capital) in a Magit diff will add this info to the commit
log for you.
Andy
prev parent reply other threads:[~2017-04-25 7:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-17 23:53 bug#26149: SRFI-19 doc erroneously warns about Gregorian reform Zefram
2017-04-19 14:42 ` Andy Wingo
2017-04-19 16:11 ` Zefram
2017-04-25 7:44 ` Andy Wingo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r30hszgq.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=26149-done@debbugs.gnu.org \
--cc=zefram@fysh.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).