From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#26149: SRFI-19 doc erroneously warns about Gregorian reform Date: Tue, 25 Apr 2017 09:44:53 +0200 Message-ID: <87r30hszgq.fsf@pobox.com> References: <20170317235307.GF6518@fysh.org> <878tmwmpam.fsf@igalia.com> <20170419161139.GA16454@fysh.org> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1493106377 28011 195.159.176.226 (25 Apr 2017 07:46:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 25 Apr 2017 07:46:17 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 26149-done@debbugs.gnu.org To: Zefram Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Tue Apr 25 09:46:14 2017 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2vAr-00079C-IM for guile-bugs@m.gmane.org; Tue, 25 Apr 2017 09:46:13 +0200 Original-Received: from localhost ([::1]:47454 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2vAv-0005W2-Qu for guile-bugs@m.gmane.org; Tue, 25 Apr 2017 03:46:17 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57274) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1d2vAk-0005TV-QD for bug-guile@gnu.org; Tue, 25 Apr 2017 03:46:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1d2vAh-0005FX-Gz for bug-guile@gnu.org; Tue, 25 Apr 2017 03:46:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:40572) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1d2vAh-0005FR-Db for bug-guile@gnu.org; Tue, 25 Apr 2017 03:46:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1d2vAh-0002fc-7P for bug-guile@gnu.org; Tue, 25 Apr 2017 03:46:03 -0400 Resent-From: Andy Wingo Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Tue, 25 Apr 2017 07:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 26149 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Mail-Followup-To: 26149@debbugs.gnu.org, wingo@pobox.com, zefram@fysh.org Original-Received: via spool by 26149-done@debbugs.gnu.org id=D26149.149310630910156 (code D ref 26149); Tue, 25 Apr 2017 07:46:02 +0000 Original-Received: (at 26149-done) by debbugs.gnu.org; 25 Apr 2017 07:45:09 +0000 Original-Received: from localhost ([127.0.0.1]:38767 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2v9p-0002dk-Cg for submit@debbugs.gnu.org; Tue, 25 Apr 2017 03:45:09 -0400 Original-Received: from pb-sasl1.pobox.com ([64.147.108.66]:59307 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d2v9n-0002db-DE for 26149-done@debbugs.gnu.org; Tue, 25 Apr 2017 03:45:07 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id 510ED73BBD; Tue, 25 Apr 2017 03:45:03 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=BVA2oQa8xsWi7cHnk/PEv6jjw0Y=; b=RcJZOP m5ILiCFmzJ/T1dLIsBdQMG0LLSlgyPouZyJChWf1VLbagvXMEqcjqhUyWyGmt9Lz frS3FB6DMFoifS/M5pG306JgKlMYyVvvaoVKMiiGi7dmYJhN2JobK95/JfB8G3dp EcHdwyhHUKYq6ValLxXvHoLg8KjVXswYraVT4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=pcOm1CglHQAPIA08Q76FZDpx3SY+hh7F DkFwhfPJPHSsnKphQCkPVlMeQU9rWV8bPzcVCe4g2tzi3iSC6smuZ51MvFdV2GlH eoz5ZchvukymR8nTpD9FKcixIpOVOWTPLBu89vSm23GABG7/AxjAKVdhzOz5z4Yr pigIkDrYz10= Original-Received: from pb-sasl1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id 47E0E73BBB; Tue, 25 Apr 2017 03:45:03 -0400 (EDT) Original-Received: from clucks (unknown [151.127.12.20]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id A0AD773BB8; Tue, 25 Apr 2017 03:45:01 -0400 (EDT) In-Reply-To: <20170419161139.GA16454@fysh.org> (zefram@fysh.org's message of "Wed, 19 Apr 2017 17:11:39 +0100") X-Pobox-Relay-ID: 16E960FC-298B-11E7-A4B6-07D2064AB293-02397024!pb-sasl1.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8786 Archived-At: On Wed 19 Apr 2017 18:11, Zefram writes: > Andy Wingo wrote: >>This makes sense to me, FWIW. > > Patch attached. Thank you! Applied. I adapted the change log message to follow Guile conventions; it was: > From 444703940983d559935c4dd2a2c89d7888c67119 Mon Sep 17 00:00:00 2001 > From: Zefram > Date: Wed, 19 Apr 2017 17:08:30 +0100 > Subject: [PATCH] correct note about Gregorian reform in SRFI-19 > > SRFI-19 specifies proleptic use of the Gregorian calendar, so it was > incorrect of the documentation to describe the code as erroneous in > doing so. Rewrite the caution more neutrally, and move it to the section > about the "date" structure, where it seems most relevant. As applied: Correct note about Gregorian reform in SRFI-19 * doc/ref/srfi-modules.texi (SRFI-19): SRFI-19 specifies proleptic use of the Gregorian calendar, so it was incorrect of the documentation to describe the code as erroneous in doing so. Rewrite the caution more neutrally, and move it to the section about the "date" structure, where it seems most relevant. Note capitalization of the summary line and an inclusion of the file and section/function in the commit message. I know the file is redundant but this is how we currently do it. If you use Emacs and Magit, pressing "C" (capital) in a Magit diff will add this info to the commit log for you. Andy