From: Andy Wingo <wingo@pobox.com>
To: Christopher Allan Webber <cwebber@dustycloud.org>
Cc: 21514@debbugs.gnu.org
Subject: bug#21514: Guile 2.2: Sluggish elf calls, esp around arity / promises / statprof
Date: Fri, 24 Jun 2016 13:37:11 +0200 [thread overview]
Message-ID: <87por6g6mw.fsf@pobox.com> (raw)
In-Reply-To: <871tbt7047.fsf@dustycloud.org> (Christopher Allan Webber's message of "Fri, 13 Nov 2015 20:54:43 -0600")
I'm happy with this fix! However I think I would like to see if I can
just speed up thunk? and other arity accessors. Do you have a test
case that you can use to show the speed problem?
Andy
On Sat 14 Nov 2015 03:54, Christopher Allan Webber <cwebber@dustycloud.org> writes:
> Here's a fix to this bug. Tests pass, and performance appears to be
> back here.
>
> I've assigned copyright to the FSF for Guile so it should be fine to
> commit!
>
>
>>From 79e3b5286a2699f9b302bd3abf8a6b884b13a4f4 Mon Sep 17 00:00:00 2001
> From: Christopher Allan Webber <cwebber@dustycloud.org>
> Date: Fri, 13 Nov 2015 20:42:31 -0600
> Subject: [PATCH] Remove thunk / arity check in make-promise
>
> * libguile/promises.c (s_scm_make_promise): Remove arity check in
> make-promise. This was causing considerably slowdown with the new elf
> code, causing considerable number of bytevector reading calls on
> every call to (make-promise). Removing this check fixes a performance
> regression in the new compiler.
> ---
> libguile/promises.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/libguile/promises.c b/libguile/promises.c
> index dcd0ac3..858b6f3 100644
> --- a/libguile/promises.c
> +++ b/libguile/promises.c
> @@ -1,4 +1,4 @@
> -/* Copyright (C) 1995,1996,1997,1998,1999,2000,2001,2002,2003,2004,2005,2006,2007,2008,2009,2010,2011
> +/* Copyright (C) 1995,1996,1997,1998,1999,2000,2001,2002,2003,2004,2005,2006,2007,2008,2009,2010,2011,2015
> * Free Software Foundation, Inc.
> *
> * This library is free software; you can redistribute it and/or
> @@ -77,7 +77,6 @@ SCM_DEFINE (scm_make_promise, "make-promise", 1, 0, 0,
> "@end lisp\n")
> #define FUNC_NAME s_scm_make_promise
> {
> - SCM_VALIDATE_THUNK (1, thunk);
> SCM_RETURN_NEWSMOB2 (scm_tc16_promise,
> SCM_UNPACK (thunk),
> SCM_UNPACK (scm_make_recursive_mutex ()));
next prev parent reply other threads:[~2016-06-24 11:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-18 15:19 bug#21514: Guile 2.2: Sluggish elf calls, esp around arity / promises / statprof Christopher Allan Webber
2015-11-14 2:54 ` Christopher Allan Webber
2016-06-24 11:37 ` Andy Wingo [this message]
2016-06-24 12:24 ` Andy Wingo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87por6g6mw.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=21514@debbugs.gnu.org \
--cc=cwebber@dustycloud.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).