From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#21514: Guile 2.2: Sluggish elf calls, esp around arity / promises / statprof Date: Fri, 24 Jun 2016 13:37:11 +0200 Message-ID: <87por6g6mw.fsf@pobox.com> References: <874mirbv8x.fsf@dustycloud.org> <871tbt7047.fsf@dustycloud.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1466768312 31915 80.91.229.3 (24 Jun 2016 11:38:32 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jun 2016 11:38:32 +0000 (UTC) Cc: 21514@debbugs.gnu.org To: Christopher Allan Webber Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Fri Jun 24 13:38:21 2016 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bGPRE-0003Ul-Bi for guile-bugs@m.gmane.org; Fri, 24 Jun 2016 13:38:20 +0200 Original-Received: from localhost ([::1]:42744 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGPRA-0003P5-8y for guile-bugs@m.gmane.org; Fri, 24 Jun 2016 07:38:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53356) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGPR0-0003GV-7S for bug-guile@gnu.org; Fri, 24 Jun 2016 07:38:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bGPQw-0004rW-RI for bug-guile@gnu.org; Fri, 24 Jun 2016 07:38:06 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:41126) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bGPQv-0004qd-VS for bug-guile@gnu.org; Fri, 24 Jun 2016 07:38:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bGPQv-0008S7-LZ for bug-guile@gnu.org; Fri, 24 Jun 2016 07:38:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Andy Wingo Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Fri, 24 Jun 2016 11:38:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 21514 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Original-Received: via spool by 21514-submit@debbugs.gnu.org id=B21514.146676824432439 (code B ref 21514); Fri, 24 Jun 2016 11:38:01 +0000 Original-Received: (at 21514) by debbugs.gnu.org; 24 Jun 2016 11:37:24 +0000 Original-Received: from localhost ([127.0.0.1]:53463 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGPQK-0008R8-AD for submit@debbugs.gnu.org; Fri, 24 Jun 2016 07:37:24 -0400 Original-Received: from pb-sasl1.pobox.com ([64.147.108.66]:50509 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bGPQG-0008Qy-EN for 21514@debbugs.gnu.org; Fri, 24 Jun 2016 07:37:23 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id D5A8E1CE92; Fri, 24 Jun 2016 07:37:19 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=jdvNHq6TxDfuH+v3Sw03j49OEzQ=; b=iM1rCE 0j1uiARatPnrT0eUGAc1WziiATbNQB1oNLrFn61fAedH1fyx5meQ0TCuEL0kVZmu bcGE6ZpTjdkk+TXE1A4s4ykTuAIMnlh5VYkruBYk+NZP3OS3/nmAIciWyqa8e92U NW/UlnJhPmxlDKuP5O6N8md1UPH6iXkHyOtlk= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=BjSr71sVYDVCsIfXP+HZOobA4chGNXqG VqQEfP0qRjMXWr069Iax1tTKJOeQFAUxhI7JkXIx+/x7HpsU9ddmEl6zsS0Qt0p+ 9gabAHID19voT78A9rBBklyyP+EyqyifrX2HnfvD5t0IgaBFZ3f2/UQKuDfqDUxX Q0AsuYLVvxc= Original-Received: from pb-sasl1.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl1.pobox.com (Postfix) with ESMTP id CC5051CE91; Fri, 24 Jun 2016 07:37:19 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl1.pobox.com (Postfix) with ESMTPSA id 1C2051CE90; Fri, 24 Jun 2016 07:37:19 -0400 (EDT) In-Reply-To: <871tbt7047.fsf@dustycloud.org> (Christopher Allan Webber's message of "Fri, 13 Nov 2015 20:54:43 -0600") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) X-Pobox-Relay-ID: 022E775E-3A00-11E6-97DB-C1836462E9F6-02397024!pb-sasl1.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8219 Archived-At: I'm happy with this fix! However I think I would like to see if I can just speed up thunk? and other arity accessors. Do you have a test case that you can use to show the speed problem? Andy On Sat 14 Nov 2015 03:54, Christopher Allan Webber writes: > Here's a fix to this bug. Tests pass, and performance appears to be > back here. > > I've assigned copyright to the FSF for Guile so it should be fine to > commit! > > >>>From 79e3b5286a2699f9b302bd3abf8a6b884b13a4f4 Mon Sep 17 00:00:00 2001 > From: Christopher Allan Webber > Date: Fri, 13 Nov 2015 20:42:31 -0600 > Subject: [PATCH] Remove thunk / arity check in make-promise > > * libguile/promises.c (s_scm_make_promise): Remove arity check in > make-promise. This was causing considerably slowdown with the new elf > code, causing considerable number of bytevector reading calls on > every call to (make-promise). Removing this check fixes a performance > regression in the new compiler. > --- > libguile/promises.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libguile/promises.c b/libguile/promises.c > index dcd0ac3..858b6f3 100644 > --- a/libguile/promises.c > +++ b/libguile/promises.c > @@ -1,4 +1,4 @@ > -/* Copyright (C) 1995,1996,1997,1998,1999,2000,2001,2002,2003,2004,2005,2006,2007,2008,2009,2010,2011 > +/* Copyright (C) 1995,1996,1997,1998,1999,2000,2001,2002,2003,2004,2005,2006,2007,2008,2009,2010,2011,2015 > * Free Software Foundation, Inc. > * > * This library is free software; you can redistribute it and/or > @@ -77,7 +77,6 @@ SCM_DEFINE (scm_make_promise, "make-promise", 1, 0, 0, > "@end lisp\n") > #define FUNC_NAME s_scm_make_promise > { > - SCM_VALIDATE_THUNK (1, thunk); > SCM_RETURN_NEWSMOB2 (scm_tc16_promise, > SCM_UNPACK (thunk), > SCM_UNPACK (scm_make_recursive_mutex ()));