From: David Kastrup <dak@gnu.org>
To: 17049@debbugs.gnu.org
Subject: bug#17049: [PATCH v2] Make reverse! forego the cost of SCM_VALIDATE_LIST
Date: Tue, 01 Apr 2014 12:40:53 +0200 [thread overview]
Message-ID: <87ob0ljpsa.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <1396348019-7418-1-git-send-email-dak@gnu.org> (David Kastrup's message of "Tue, 1 Apr 2014 12:26:59 +0200")
Sigh. In case you are committing this, there might be one minor change
worth doing to match the coding style:
> + scm_wrong_type_arg (FUNC_NAME, 1, lst);
This should likely be
SCM_WRONG_TYPE_ARG (1, lst);
for consistency with other usage in list.c. I can reroll if you prefer
this over fixing it yourself.
--
David Kastrup
next prev parent reply other threads:[~2014-04-01 10:40 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-20 11:23 bug#17049: [PATCH] Make reverse! forego the cost of SCM_VALIDATE_LIST David Kastrup
2014-03-20 11:38 ` bug#17049: PostScriptum: David Kastrup
2014-03-20 14:19 ` bug#17049: [PATCH] Make reverse! forego the cost of SCM_VALIDATE_LIST David Kastrup
2014-03-20 20:50 ` Andy Wingo
2014-03-20 21:27 ` David Kastrup
2014-03-21 4:38 ` Mark H Weaver
2014-03-21 16:56 ` David Kastrup
2014-03-31 19:56 ` Mark H Weaver
2014-04-01 10:26 ` bug#17049: [PATCH v2] " David Kastrup
2014-04-01 10:40 ` David Kastrup [this message]
2014-04-01 14:09 ` Mark H Weaver
2014-04-01 14:24 ` bug#17049: [PATCH v3] " David Kastrup
2014-04-01 16:35 ` Mark H Weaver
2014-03-21 17:44 ` bug#17049: [PATCH] " David Kastrup
2014-03-30 16:36 ` bug#17049: Further change ideas David Kastrup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ob0ljpsa.fsf@fencepost.gnu.org \
--to=dak@gnu.org \
--cc=17049@debbugs.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).