From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Kastrup Newsgroups: gmane.lisp.guile.bugs Subject: bug#17049: [PATCH v2] Make reverse! forego the cost of SCM_VALIDATE_LIST Date: Tue, 01 Apr 2014 12:40:53 +0200 Message-ID: <87ob0ljpsa.fsf@fencepost.gnu.org> References: <87zjk6m9ap.fsf@yeeloong.lan> <1396348019-7418-1-git-send-email-dak@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1396348985 8734 80.91.229.3 (1 Apr 2014 10:43:05 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 1 Apr 2014 10:43:05 +0000 (UTC) To: 17049@debbugs.gnu.org Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Tue Apr 01 12:42:59 2014 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WUw7x-0007Ha-Pl for guile-bugs@m.gmane.org; Tue, 01 Apr 2014 12:41:09 +0200 Original-Received: from localhost ([::1]:59523 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUw7x-0006CY-5s for guile-bugs@m.gmane.org; Tue, 01 Apr 2014 06:41:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43974) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUw7t-00069d-4p for bug-guile@gnu.org; Tue, 01 Apr 2014 06:41:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WUw7s-0006W5-DG for bug-guile@gnu.org; Tue, 01 Apr 2014 06:41:05 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57665) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUw7s-0006Vc-8y for bug-guile@gnu.org; Tue, 01 Apr 2014 06:41:04 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1WUw7r-0007ML-5m for bug-guile@gnu.org; Tue, 01 Apr 2014 06:41:03 -0400 X-Loop: help-debbugs@gnu.org Resent-From: David Kastrup Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Tue, 01 Apr 2014 10:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 17049 X-GNU-PR-Package: guile X-GNU-PR-Keywords: patch Original-Received: via spool by 17049-submit@debbugs.gnu.org id=B17049.139634885928270 (code B ref 17049); Tue, 01 Apr 2014 10:41:02 +0000 Original-Received: (at 17049) by debbugs.gnu.org; 1 Apr 2014 10:40:59 +0000 Original-Received: from localhost ([127.0.0.1]:58847 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WUw7m-0007Lt-8v for submit@debbugs.gnu.org; Tue, 01 Apr 2014 06:40:58 -0400 Original-Received: from fencepost.gnu.org ([208.118.235.10]:56021) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1WUw7i-0007Lj-8m for 17049@debbugs.gnu.org; Tue, 01 Apr 2014 06:40:54 -0400 Original-Received: from localhost ([127.0.0.1]:35095 helo=lola) by fencepost.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WUw7h-0006JR-Qm; Tue, 01 Apr 2014 06:40:54 -0400 Original-Received: by lola (Postfix, from userid 1000) id 5E8BEDF3B4; Tue, 1 Apr 2014 12:40:53 +0200 (CEST) In-Reply-To: <1396348019-7418-1-git-send-email-dak@gnu.org> (David Kastrup's message of "Tue, 1 Apr 2014 12:26:59 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.bugs:7438 Archived-At: Sigh. In case you are committing this, there might be one minor change worth doing to match the coding style: > + scm_wrong_type_arg (FUNC_NAME, 1, lst); This should likely be SCM_WRONG_TYPE_ARG (1, lst); for consistency with other usage in list.c. I can reroll if you prefer this over fixing it yourself. -- David Kastrup