bug#18470: Bug#761408: will FTBFS when libtool no longer depends on libtool-bin #682045

bug#18470: Bug#761408: will FTBFS when libtool no longer depends on libtool-bin #682045

[Rob Browning]

[If possible, please preserve the -forwarded address in any replies.]

For the reasons stated below, we're going to switch to call
(g)libtoolize in Debian rather than (g)libtool.  I thought I'd mention
it in case it's relevant upstream.

More info here: 

  https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=761408

Helmut Grohne <helmut@subdivi.de> writes:

> Package: src:guile-2.0
> Version: 2.0.11+1-1
> Severity: normal
> Tags: patch
> User: helmutg@debian.org
> Usertags: rebootstrap
>
> Hi Rob,
>
> While building with a split libtool (see #682045), guile failed to
> build, because it checks for libtool in autogen.sh, but libtool is in
> the package libtool-bin and the package libtool no longer depends on
> libtool-bin. guile only really uses libtoolize though, so all that is
> broken is the test in autogen.sh. Please find a patch attached, that
> fixes autogen.sh.
>
> This bug will become rc when #682045 is fixed.
>
> Helmut
> diff -Nru guile-2.0-2.0.11+1/debian/changelog guile-2.0-2.0.11+1/debian/changelog
> --- guile-2.0-2.0.11+1/debian/changelog	2014-04-23 19:19:00.000000000 +0200
> +++ guile-2.0-2.0.11+1/debian/changelog	2014-09-13 15:32:44.000000000 +0200
> @@ -1,3 +1,10 @@
> +guile-2.0 (2.0.11+1-1.1) UNRELEASED; urgency=low
> +
> +  * Non-maintainer upload.
> +  * Check for libtoolize rather than libtool, because #682045. (Closes: #-1)
> +
> + -- Helmut Grohne <helmut@subdivi.de>  Sat, 13 Sep 2014 15:31:58 +0200
> +
>  guile-2.0 (2.0.11+1-1) unstable; urgency=low
>  
>    * Incorporate upstream version 2.0.11.
> diff -Nru guile-2.0-2.0.11+1/debian/patches/libtoolize-check.patch guile-2.0-2.0.11+1/debian/patches/libtoolize-check.patch
> --- guile-2.0-2.0.11+1/debian/patches/libtoolize-check.patch	1970-01-01 01:00:00.000000000 +0100
> +++ guile-2.0-2.0.11+1/debian/patches/libtoolize-check.patch	2014-09-13 15:36:08.000000000 +0200
> @@ -0,0 +1,23 @@
> +From: Helmut Grohne <helmut@subdivi.de>
> +Date: Sat, 13 Sep 2014 15:35:09 +0200
> +Subject: Check for libtoolize rather than libtool
> +
> +libtool is being split out to libtool-bin, but guile only really needs
> +libtoolize from the libtool package. See #682045.
> +
> +Index: guile-2.0-2.0.11+1/autogen.sh
> +===================================================================
> +--- guile-2.0-2.0.11+1.orig/autogen.sh	2014-03-20 21:21:21.000000000 +0100
> ++++ guile-2.0-2.0.11+1/autogen.sh	2014-09-13 15:34:22.455478639 +0200
> +@@ -16,9 +16,9 @@
> + automake --version
> + echo ""
> + if test "`uname -s`" = Darwin; then
> +-  glibtool --version
> ++  glibtoolize --version
> + else
> +-  libtool --version
> ++  libtoolize --version
> + fi
> + echo ""
> + ${M4:-m4} --version
> diff -Nru guile-2.0-2.0.11+1/debian/patches/series guile-2.0-2.0.11+1/debian/patches/series
> --- guile-2.0-2.0.11+1/debian/patches/series	2014-04-23 19:11:29.000000000 +0200
> +++ guile-2.0-2.0.11+1/debian/patches/series	2014-09-13 15:33:45.000000000 +0200
> @@ -1,2 +1,3 @@
>  0001-Change-guile-to-guile-X.Y-for-info-pages.patch
>  0002-Mark-mutex-with-owner-not-retained-threads-test-as-u.patch
> +libtoolize-check.patch

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4

bug#18470: Bug#761408: will FTBFS when libtool no longer depends on libtool-bin #682045

[Ludovic Courtès]

Rob Browning <rlb@defaultvalue.org> skribis:

> For the reasons stated below, we're going to switch to call
> (g)libtoolize in Debian rather than (g)libtool.  I thought I'd mention
> it in case it's relevant upstream.

Yes, it makes more sense to invoke ‘libtoolize’ here (the installed
‘libtool’ script is never really used.)

Pushed as 76a8db2.

Thanks for sharing.

Ludo’.