unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* bug#24207: Fixing documentation example for make-custom-binary-input-port
@ 2016-08-11 20:13 Christopher Allan Webber
  2016-08-31 13:51 ` Andy Wingo
  0 siblings, 1 reply; 2+ messages in thread
From: Christopher Allan Webber @ 2016-08-11 20:13 UTC (permalink / raw)
  To: 24207

[-- Attachment #1: Type: text/plain, Size: 92 bytes --]

The example previously did not run, because it was missing the "closed"
parameter.  Fixed.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-example-in-make-custom-binary-input-port-documen.patch --]
[-- Type: text/x-patch, Size: 1476 bytes --]

From abed180e8ea3ada5c4e156165f0b5e648d517ba2 Mon Sep 17 00:00:00 2001
From: Christopher Allan Webber <cwebber@dustycloud.org>
Date: Thu, 11 Aug 2016 15:10:19 -0500
Subject: [PATCH] Fix example in make-custom-binary-input-port documentation

* doc/ref/api-io.texi (Custom Ports): Add additional argument to example's
  invocation of make-custom-binary-input-port.  Previously had mismatched arity
  by missing "closed" argument.
---
 doc/ref/api-io.texi | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/doc/ref/api-io.texi b/doc/ref/api-io.texi
index 76c8db8..e4e4f36 100644
--- a/doc/ref/api-io.texi
+++ b/doc/ref/api-io.texi
@@ -1,7 +1,7 @@
 @c -*-texinfo-*-
 @c This is part of the GNU Guile Reference Manual.
 @c Copyright (C)  1996, 1997, 2000, 2001, 2002, 2003, 2004, 2007, 2009,
-@c   2010, 2011, 2013  Free Software Foundation, Inc.
+@c   2010, 2011, 2013, 2016  Free Software Foundation, Inc.
 @c See the file guile.texi for copying conditions.
 
 @node Input and Output
@@ -1278,8 +1278,8 @@ procedure (@pxref{Bytevector Ports}) could be implemented as follows:
     (set! position new-position))
 
   (make-custom-binary-input-port "the port" read!
-                                  get-position
-                                  set-position!))
+                                  get-position set-position!
+                                  #f))
 
 (read (open-bytevector-input-port (string->utf8 "hello")))
 @result{} hello
-- 
2.9.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* bug#24207: Fixing documentation example for make-custom-binary-input-port
  2016-08-11 20:13 bug#24207: Fixing documentation example for make-custom-binary-input-port Christopher Allan Webber
@ 2016-08-31 13:51 ` Andy Wingo
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Wingo @ 2016-08-31 13:51 UTC (permalink / raw)
  To: Christopher Allan Webber; +Cc: 24207-done

On Thu 11 Aug 2016 22:13, Christopher Allan Webber <cwebber@dustycloud.org> writes:

> The example previously did not run, because it was missing the "closed"
> parameter.  Fixed.

Applied, thanks :)





^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-08-31 13:51 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-11 20:13 bug#24207: Fixing documentation example for make-custom-binary-input-port Christopher Allan Webber
2016-08-31 13:51 ` Andy Wingo

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).