* bug#19939: http client: Chunks shouldn't be read at once
@ 2015-02-24 20:59 Ludovic Courtès
2015-03-01 22:44 ` Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: Ludovic Courtès @ 2015-02-24 20:59 UTC (permalink / raw)
To: 19939
As of 2.0.11, the chunked input port of the HTTP client reads whole
chunks at once:
--8<---------------cut here---------------start------------->8---
(define (read-chunk port)
(let ((size (read-chunk-header port)))
(read-chunk-body port size)))
(define (read-chunk-body port size)
(let ((bv (get-bytevector-n port size)))
(get-u8 port) ; CR
(get-u8 port) ; LF
bv))
(define* (make-chunked-input-port port #:key (keep-alive? #f))
"Returns a new port which translates HTTP chunked transfer encoded
data from PORT into a non-encoded format. Returns eof when it has
read the final chunk from PORT. This does not necessarily mean
that there is no more data on PORT. When the returned port is
closed it will also close PORT, unless the KEEP-ALIVE? is true."
(define (next-chunk)
(read-chunk port))
[...]
(define (read! bv idx to-read)
[...]
(set! buffer (next-chunk))
[...]
(make-custom-binary-input-port "chunked input port" read! #f #f close))
--8<---------------cut here---------------end--------------->8---
This is undesirable because:
1. the HTTP server can produce arbitrarily large chunks, leading to
large memory use in the client (nginx does indeed produce very
large chunks in some cases);
2. it adds an extra level of buffering that the caller of ‘http-get’
does not control (a read of 1 byte from the HTTP body port leads
to an actual read of a whole chunk);
3. it introduces extra copying and allocations.
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
* bug#19939: http client: Chunks shouldn't be read at once
2015-02-24 20:59 bug#19939: http client: Chunks shouldn't be read at once Ludovic Courtès
@ 2015-03-01 22:44 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2015-03-01 22:44 UTC (permalink / raw)
To: 19939-done
Fixed in commit 00d3ecf, which will be in 2.0.12.
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-03-01 22:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-02-24 20:59 bug#19939: http client: Chunks shouldn't be read at once Ludovic Courtès
2015-03-01 22:44 ` Ludovic Courtès
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).