From: ludo@gnu.org (Ludovic Courtès)
To: Andy Wingo <wingo@igalia.com>
Cc: 29226-done@debbugs.gnu.org
Subject: bug#29226: fresh-auto-compile doesn’t invalidate the compilation cache
Date: Mon, 15 Jan 2018 23:21:19 +0100 [thread overview]
Message-ID: <87h8rmg3vk.fsf@gnu.org> (raw)
In-Reply-To: <87h8rnb2no.fsf@igalia.com> (Andy Wingo's message of "Mon, 15 Jan 2018 15:46:35 +0100")
Andy Wingo <wingo@igalia.com> skribis:
> On Mon 15 Jan 2018 15:33, ludo@gnu.org (Ludovic Courtès) writes:
>
>> Hello,
>>
>> ludovic.courtes@inria.fr (Ludovic Courtès) skribis:
>>
>>> ‘%fresh-auto-compile’ is documented as a way to “forcibly invalidate the
>>> auto-compilation cache” (info "(guile) Compilation"), but it seems that
>>> it doesn’t invalidate much. Specifically, ‘primitive-load-path’ does:
>>>
>>> compiled_thunk = load_thunk_from_path (filename, full_filename, &stat_source,
>>> &found_stale_compiled_file);
>>>
>>> if (scm_is_false (compiled_thunk)
>>> && scm_is_false (*scm_loc_fresh_auto_compile)
>>> …)
>>> { … }
>>>
>>> …
>>>
>>> if (scm_is_true (compiled_thunk))
>>> return scm_call_0 (compiled_thunk);
>>> else
>>> {
>>> SCM freshly_compiled = scm_try_auto_compile (full_filename);
>>> …
>>> }
>>>
>>> So if there’s a .go file in the search path, it is *always* loaded, and
>>> there’s no way we reach ‘scm_try_auto_compile’.
>>>
>>> ‘load-absolute’ in boot-9.scm seems to have the same problem:
>>>
>>> (and scmstat (or (pre-compiled) (fallback)))
>>>
>>> I believe the attached patch fixes it.
>>
>>> Pushed as 83d4c4d622b406ec0bc9d8139ec8182fa72b5720.
>>
>> As we’ve discussed since then, this patch was misguided:
>> ‘%fresh-auto-compile’ is about ~/.cache, so the fact that .go files
>> found elsewhere in the search path get loaded is expected.
>>
>> My apologies for breaking this!
>>
>> So I guess we should revert 83d4c4d622b406ec0bc9d8139ec8182fa72b5720 and
>> release 2.2.4 afterwards. Does that make sense, Andy?
>
> Makes sense to me, yes!
OK, reverted in a1793bc904d947810d64175945218c2cdace38cc.
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-01-15 22:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 12:53 bug#29226: fresh-auto-compile doesn’t invalidate the compilation cache Ludovic Courtès
2017-11-22 15:48 ` Ludovic Courtès
[not found] ` <87shb7fayt.fsf@gnu.org>
[not found] ` <87h8rnb2no.fsf@igalia.com>
2018-01-15 22:21 ` Ludovic Courtès [this message]
2018-01-16 18:18 ` David Pirotte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87h8rmg3vk.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=29226-done@debbugs.gnu.org \
--cc=wingo@igalia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).