From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.bugs Subject: bug#29226: fresh-auto-compile =?UTF-8?Q?doesn=E2=80=99t?= invalidate the compilation cache Date: Mon, 15 Jan 2018 23:21:19 +0100 Message-ID: <87h8rmg3vk.fsf@gnu.org> References: <87zi7vmx4t.fsf@inria.fr> <87shb7fayt.fsf@gnu.org> <87h8rnb2no.fsf@igalia.com> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: blaine.gmane.org 1516054819 2417 195.159.176.226 (15 Jan 2018 22:20:19 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 15 Jan 2018 22:20:19 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.3 (gnu/linux) Cc: 29226-done@debbugs.gnu.org To: Andy Wingo Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Mon Jan 15 23:20:15 2018 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebD6z-0000BL-10 for guile-bugs@m.gmane.org; Mon, 15 Jan 2018 23:20:13 +0100 Original-Received: from localhost ([::1]:39438 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebD8y-0006CY-Vh for guile-bugs@m.gmane.org; Mon, 15 Jan 2018 17:22:17 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60316) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ebD8o-0006BJ-Oh for bug-guile@gnu.org; Mon, 15 Jan 2018 17:22:07 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ebD8l-000564-CV for bug-guile@gnu.org; Mon, 15 Jan 2018 17:22:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49961) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ebD8l-00055s-9e for bug-guile@gnu.org; Mon, 15 Jan 2018 17:22:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ebD8l-00042a-4F for bug-guile@gnu.org; Mon, 15 Jan 2018 17:22:03 -0500 Resent-From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Mon, 15 Jan 2018 22:22:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 29226 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Mail-Followup-To: 29226@debbugs.gnu.org, ludo@gnu.org, ludovic.courtes@inria.fr Original-Received: via spool by 29226-done@debbugs.gnu.org id=D29226.151605488915455 (code D ref 29226); Mon, 15 Jan 2018 22:22:02 +0000 Original-Received: (at 29226-done) by debbugs.gnu.org; 15 Jan 2018 22:21:29 +0000 Original-Received: from localhost ([127.0.0.1]:57851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebD8D-000417-EE for submit@debbugs.gnu.org; Mon, 15 Jan 2018 17:21:29 -0500 Original-Received: from hera.aquilenet.fr ([185.233.100.1]:44250) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ebD88-00040r-0A for 29226-done@debbugs.gnu.org; Mon, 15 Jan 2018 17:21:26 -0500 Original-Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 81A1410B76; Mon, 15 Jan 2018 23:21:22 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Original-Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 6mtPYyDtsXpD; Mon, 15 Jan 2018 23:21:20 +0100 (CET) Original-Received: from ribbon (unknown [IPv6:2a01:e0a:1d:7270:af76:b9b:ca24:c465]) by hera.aquilenet.fr (Postfix) with ESMTPSA id F18AF109B6; Mon, 15 Jan 2018 23:21:19 +0100 (CET) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 =?UTF-8?Q?Niv=C3=B4se?= an 226 de la =?UTF-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu In-Reply-To: <87h8rnb2no.fsf@igalia.com> (Andy Wingo's message of "Mon, 15 Jan 2018 15:46:35 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8967 Archived-At: Andy Wingo skribis: > On Mon 15 Jan 2018 15:33, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > >> Hello, >> >> ludovic.courtes@inria.fr (Ludovic Court=C3=A8s) skribis: >> >>> =E2=80=98%fresh-auto-compile=E2=80=99 is documented as a way to =E2=80= =9Cforcibly invalidate the >>> auto-compilation cache=E2=80=9D (info "(guile) Compilation"), but it se= ems that >>> it doesn=E2=80=99t invalidate much. Specifically, =E2=80=98primitive-l= oad-path=E2=80=99 does: >>> >>> compiled_thunk =3D load_thunk_from_path (filename, full_filename, &st= at_source, >>> &found_stale_compiled_file); >>> >>> if (scm_is_false (compiled_thunk) >>> && scm_is_false (*scm_loc_fresh_auto_compile) >>> =E2=80=A6) >>> { =E2=80=A6 } >>> >>> =E2=80=A6 >>> >>> if (scm_is_true (compiled_thunk)) >>> return scm_call_0 (compiled_thunk); >>> else >>> { >>> SCM freshly_compiled =3D scm_try_auto_compile (full_filename); >>> =E2=80=A6 >>> } >>> >>> So if there=E2=80=99s a .go file in the search path, it is *always* loa= ded, and >>> there=E2=80=99s no way we reach =E2=80=98scm_try_auto_compile=E2=80=99. >>> >>> =E2=80=98load-absolute=E2=80=99 in boot-9.scm seems to have the same pr= oblem: >>> >>> (and scmstat (or (pre-compiled) (fallback))) >>> >>> I believe the attached patch fixes it. >> >>> Pushed as 83d4c4d622b406ec0bc9d8139ec8182fa72b5720. >> >> As we=E2=80=99ve discussed since then, this patch was misguided: >> =E2=80=98%fresh-auto-compile=E2=80=99 is about ~/.cache, so the fact tha= t .go files >> found elsewhere in the search path get loaded is expected. >> >> My apologies for breaking this! >> >> So I guess we should revert 83d4c4d622b406ec0bc9d8139ec8182fa72b5720 and >> release 2.2.4 afterwards. Does that make sense, Andy? > > Makes sense to me, yes! OK, reverted in a1793bc904d947810d64175945218c2cdace38cc. Thanks, Ludo=E2=80=99.