unofficial mirror of bug-guile@gnu.org 
 help / color / mirror / Atom feed
* bug#57948: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.
       [not found] ` <20220922135358.22139-1-whatson@gmail.com>
@ 2022-10-12 20:34   ` Ludovic Courtès
       [not found]   ` <87czawvl0v.fsf@gnu.org>
  1 sibling, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2022-10-12 20:34 UTC (permalink / raw)
  To: Andrew Whatson; +Cc: 57948, guile-devel

Hi Andrew,

Andrew Whatson <whatson@gmail.com> skribis:

> Workaround for <https://bugs.gnu.org/57948>.
>
> * module/system/vm/frame.scm (frame-call-representation): Treat a
> binding as "unspecified" if its slot exceeds 'frame-num-locals'.

Yay, great to see that fixed (or almost)!

It would be great if you could add a simple test case though, so that
the bug doesn’t eventually come back to haunt us.

Could you send an updated patch?

Thanks,
Ludo’.

PS: BTW, it’ll be great to have more patches from you!  :-) To that end,
    please check out the new Guile copyright policy and let us know what
    option you’d like to choose:
    <https://lists.gnu.org/archive/html/guile-devel/2022-10/msg00008.html>.





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#57948: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.
       [not found]   ` <87czawvl0v.fsf@gnu.org>
@ 2022-10-13  3:36     ` Andrew Whatson
       [not found]     ` <CAPE069eQb3Yg9OdgjBw3tC2c-G2Cbo15rjkdjP=uQgvu_MNjpA@mail.gmail.com>
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Whatson @ 2022-10-13  3:36 UTC (permalink / raw)
  To: Ludovic Courtès; +Cc: 57948, guile-devel

Ludovic Courtès <ludo@gnu.org> wrote:
>
> It would be great if you could add a simple test case though, so that
> the bug doesn’t eventually come back to haunt us.
>
> Could you send an updated patch?

Ah yes, getting this covered in a test is on my list.  I had trouble
writing a reproducer previously, I think the bug might only occur in a
nested compilation context (top-level error compiling a dependency
module), but I'll have another go.

> PS: BTW, it’ll be great to have more patches from you!  :-) To that end,
>     please check out the new Guile copyright policy and let us know what
>     option you’d like to choose:
>     <https://lists.gnu.org/archive/html/guile-devel/2022-10/msg00008.html>.

I have already assigned copyright of my work on Guile to the FSF,
happy for that to remain.

That said, I'm glad to see this requirement being eased!

Cheers,
Andrew





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#57948: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace.
       [not found]     ` <CAPE069eQb3Yg9OdgjBw3tC2c-G2Cbo15rjkdjP=uQgvu_MNjpA@mail.gmail.com>
@ 2022-10-13 13:09       ` Ludovic Courtès
  0 siblings, 0 replies; 3+ messages in thread
From: Ludovic Courtès @ 2022-10-13 13:09 UTC (permalink / raw)
  To: Andrew Whatson; +Cc: 57948, guile-devel

Hi,

Andrew Whatson <whatson@gmail.com> skribis:

> Ludovic Courtès <ludo@gnu.org> wrote:
>>
>> It would be great if you could add a simple test case though, so that
>> the bug doesn’t eventually come back to haunt us.
>>
>> Could you send an updated patch?
>
> Ah yes, getting this covered in a test is on my list.  I had trouble
> writing a reproducer previously, I think the bug might only occur in a
> nested compilation context (top-level error compiling a dependency
> module), but I'll have another go.

Awesome.

>> PS: BTW, it’ll be great to have more patches from you!  :-) To that end,
>>     please check out the new Guile copyright policy and let us know what
>>     option you’d like to choose:
>>     <https://lists.gnu.org/archive/html/guile-devel/2022-10/msg00008.html>.
>
> I have already assigned copyright of my work on Guile to the FSF,
> happy for that to remain.

Oh sorry I had overlooked that, perfect!

Thanks,
Ludo’.





^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-10-13 13:09 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <56d1283b-ac09-8f62-8657-de99578e1a6c@telenet.be>
     [not found] ` <20220922135358.22139-1-whatson@gmail.com>
2022-10-12 20:34   ` bug#57948: [PATCH] Avoid 'frame-local-ref' errors when printing backtrace Ludovic Courtès
     [not found]   ` <87czawvl0v.fsf@gnu.org>
2022-10-13  3:36     ` Andrew Whatson
     [not found]     ` <CAPE069eQb3Yg9OdgjBw3tC2c-G2Cbo15rjkdjP=uQgvu_MNjpA@mail.gmail.com>
2022-10-13 13:09       ` Ludovic Courtès

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).