From: Andy Wingo <wingo@pobox.com>
To: Thomas Klausner <tk@giga.or.at>
Cc: 25923-done@debbugs.gnu.org
Subject: bug#25923: pkgsrc patches: improve mkostemp support
Date: Tue, 14 Mar 2017 12:32:02 +0100 [thread overview]
Message-ID: <87efy08571.fsf@pobox.com> (raw)
In-Reply-To: <20170301202926.mh7uireewfygr4zc@danbala> (Thomas Klausner's message of "Wed, 1 Mar 2017 21:29:26 +0100")
On Wed 01 Mar 2017 21:29, Thomas Klausner <tk@giga.or.at> writes:
> --- libguile/filesys.c.orig 2016-12-15 00:03:33.000000000 +0000
> +++ libguile/filesys.c
> @@ -1486,6 +1486,15 @@ SCM_DEFINE (scm_i_mkstemp, "mkstemp!", 1
> mode_bits = scm_i_mode_bits (mode);
> }
>
> +#ifdef __APPLE__
> + /* https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24862#23 */
> + open_flags &= O_APPEND|O_SHLOCK|O_EXLOCK|O_CLOEXEC;
> +#endif
> +#ifdef __NetBSD__
> + /* Restrict to list of flags documented in man page. */
> + open_flags &= O_APPEND|O_DIRECT|O_SHLOCK|O_EXLOCK|O_SYNC|O_CLOEXEC;
> +#endif
> +
> SCM_SYSCALL (rv = mkostemp (c_tmpl, open_flags));
> if (rv == -1)
> SCM_SYSERROR;
I believe this was fixed in 2.1.6 as well so you can drop this one too.
Cheers,
Andy
prev parent reply other threads:[~2017-03-14 11:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 20:29 bug#25923: pkgsrc patches: improve mkostemp support Thomas Klausner
2017-03-14 11:32 ` Andy Wingo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87efy08571.fsf@pobox.com \
--to=wingo@pobox.com \
--cc=25923-done@debbugs.gnu.org \
--cc=tk@giga.or.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).