From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.bugs Subject: bug#25923: pkgsrc patches: improve mkostemp support Date: Tue, 14 Mar 2017 12:32:02 +0100 Message-ID: <87efy08571.fsf@pobox.com> References: <20170301202926.mh7uireewfygr4zc@danbala> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1489491522 29592 195.159.176.226 (14 Mar 2017 11:38:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Tue, 14 Mar 2017 11:38:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) Cc: 25923-done@debbugs.gnu.org To: Thomas Klausner Original-X-From: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Tue Mar 14 12:38:36 2017 Return-path: Envelope-to: guile-bugs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnkma-0006Pb-PZ for guile-bugs@m.gmane.org; Tue, 14 Mar 2017 12:38:28 +0100 Original-Received: from localhost ([::1]:57891 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnkmg-0005FI-LP for guile-bugs@m.gmane.org; Tue, 14 Mar 2017 07:38:34 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:53449) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cnkhQ-0001J5-8I for bug-guile@gnu.org; Tue, 14 Mar 2017 07:33:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cnkhK-0000bn-LC for bug-guile@gnu.org; Tue, 14 Mar 2017 07:33:08 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:56724) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cnkhK-0000bH-CB for bug-guile@gnu.org; Tue, 14 Mar 2017 07:33:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cnkhK-0003bz-7c for bug-guile@gnu.org; Tue, 14 Mar 2017 07:33:02 -0400 Resent-From: Andy Wingo Original-Sender: "Debbugs-submit" Resent-To: bug-guile@gnu.org Resent-Date: Tue, 14 Mar 2017 11:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 25923 X-GNU-PR-Package: guile X-GNU-PR-Keywords: Mail-Followup-To: 25923@debbugs.gnu.org, wingo@pobox.com, tk@giga.or.at Original-Received: via spool by 25923-done@debbugs.gnu.org id=D25923.148949113213761 (code D ref 25923); Tue, 14 Mar 2017 11:33:01 +0000 Original-Received: (at 25923-done) by debbugs.gnu.org; 14 Mar 2017 11:32:12 +0000 Original-Received: from localhost ([127.0.0.1]:54921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnkgW-0003Zl-8L for submit@debbugs.gnu.org; Tue, 14 Mar 2017 07:32:12 -0400 Original-Received: from pb-sasl2.pobox.com ([64.147.108.67]:54426 helo=sasl.smtp.pobox.com) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cnkgU-0003Wr-1n for 25923-done@debbugs.gnu.org; Tue, 14 Mar 2017 07:32:10 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id BE01F69008; Tue, 14 Mar 2017 07:32:09 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=E37ycoWsUhpfax2nhtDtSsR9wm8=; b=KihhVj ItBn+vmt8ock0zB//+62keBCeUanmo/DClTfCWoVVtx+3YnDxL7CZyzO7bNI4D6n Uqq/ERcmqkNHdwhVOhF9ATvmXRw3jNcfndIZtTadKaUGARSp4ufhtRq6mwqtPgR7 dmU6J14R3nV8vDhw1AJvYjlZSwcmKnZ8br2pc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=UEJqBZtsUzzxL6A1SaM7eXgn7Vg0Q8Dp D9S3jRZigVEW6o5l/TJNZNr5bV+js6B7idckWA/Gz5WtAF8+iq3PoQ90CfqtSWYa bCj4sfUr1v/5pTxeg9ukitWIhx5tjBFqp4JCEKF45WEJT6cfpmPvDlBxevdx7BZI 9jDfxQd26BQ= Original-Received: from pb-sasl2.nyi.icgroup.com (unknown [127.0.0.1]) by pb-sasl2.pobox.com (Postfix) with ESMTP id B774469007; Tue, 14 Mar 2017 07:32:09 -0400 (EDT) Original-Received: from clucks (unknown [88.160.190.192]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by pb-sasl2.pobox.com (Postfix) with ESMTPSA id C7E9069006; Tue, 14 Mar 2017 07:32:08 -0400 (EDT) In-Reply-To: <20170301202926.mh7uireewfygr4zc@danbala> (Thomas Klausner's message of "Wed, 1 Mar 2017 21:29:26 +0100") X-Pobox-Relay-ID: DBFCC4AE-08A9-11E7-8487-85AB91A0D1B0-02397024!pb-sasl2.pobox.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane.org@gnu.org Original-Sender: "bug-guile" Xref: news.gmane.org gmane.lisp.guile.bugs:8679 Archived-At: On Wed 01 Mar 2017 21:29, Thomas Klausner writes: > --- libguile/filesys.c.orig 2016-12-15 00:03:33.000000000 +0000 > +++ libguile/filesys.c > @@ -1486,6 +1486,15 @@ SCM_DEFINE (scm_i_mkstemp, "mkstemp!", 1 > mode_bits = scm_i_mode_bits (mode); > } > > +#ifdef __APPLE__ > + /* https://debbugs.gnu.org/cgi/bugreport.cgi?bug=24862#23 */ > + open_flags &= O_APPEND|O_SHLOCK|O_EXLOCK|O_CLOEXEC; > +#endif > +#ifdef __NetBSD__ > + /* Restrict to list of flags documented in man page. */ > + open_flags &= O_APPEND|O_DIRECT|O_SHLOCK|O_EXLOCK|O_SYNC|O_CLOEXEC; > +#endif > + > SCM_SYSCALL (rv = mkostemp (c_tmpl, open_flags)); > if (rv == -1) > SCM_SYSERROR; I believe this was fixed in 2.1.6 as well so you can drop this one too. Cheers, Andy