* bug#21117: [PATCH 4/4] Remove sigevent structure value definitions
@ 2015-07-22 16:54 David Michael
2015-10-29 22:46 ` Ludovic Courtès
0 siblings, 1 reply; 2+ messages in thread
From: David Michael @ 2015-07-22 16:54 UTC (permalink / raw)
To: 21117
* libguile/Makefile.am (chknew-E chknew-SIG): Anchor the end of the
signal/error name pattern to only match alphanumeric symbols.
* libguile/cpp-SIG.syms (SIGEV_MAX_SIZE, SIGEV_NONE): Remove.
(SIGEV_PAD_SIZE, SIGEV_SIGNAL, SIGEV_THREAD): Likewise.
(SIGEV_THREAD_ID): Likewise.
---
I'm assuming those sigevent structure values weren't intended to have
their definitions included with signals. This patch removes them and
adds stricter name matching to the regexp.
libguile/Makefile.am | 2 +-
libguile/cpp-SIG.syms | 6 ------
2 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/libguile/Makefile.am b/libguile/Makefile.am
index dfa3be0..851799a 100644
--- a/libguile/Makefile.am
+++ b/libguile/Makefile.am
@@ -821,7 +821,7 @@ chknew-E chknew-SIG:
echo "#include <$${bit}.h>" \
| sed 's/E/errno/;s/SIG/signal/' \
| gcc -dM -E - \
- | sed 's/^#define //;/^'$$bit'[0-9A-Z][0-9A-Z]*/!d;s/ .*//' \
+ | sed 's/^#define //;/^'$$bit'[0-9A-Z][0-9A-Z]* /!d;s/ .*//' \
| sort | diff -u $$old - | sed '1,2d;/^+/!d;s/^.//' \
> TMP ; \
if [ -s TMP ] ; then new="$$old.NEW" ; \
diff --git a/libguile/cpp-SIG.syms b/libguile/cpp-SIG.syms
index 2a619ce..728a294 100644
--- a/libguile/cpp-SIG.syms
+++ b/libguile/cpp-SIG.syms
@@ -6,12 +6,6 @@ SIGCHLD
SIGCLD
SIGCONT
SIGEMT
-SIGEV_MAX_SIZE
-SIGEV_NONE
-SIGEV_PAD_SIZE
-SIGEV_SIGNAL
-SIGEV_THREAD
-SIGEV_THREAD_ID
SIGFPE
SIGHUP
SIGILL
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* bug#21117: [PATCH 4/4] Remove sigevent structure value definitions
2015-07-22 16:54 bug#21117: [PATCH 4/4] Remove sigevent structure value definitions David Michael
@ 2015-10-29 22:46 ` Ludovic Courtès
0 siblings, 0 replies; 2+ messages in thread
From: Ludovic Courtès @ 2015-10-29 22:46 UTC (permalink / raw)
To: David Michael; +Cc: 21117-done
David Michael <fedora.dm0@gmail.com> skribis:
> * libguile/Makefile.am (chknew-E chknew-SIG): Anchor the end of the
> signal/error name pattern to only match alphanumeric symbols.
> * libguile/cpp-SIG.syms (SIGEV_MAX_SIZE, SIGEV_NONE): Remove.
> (SIGEV_PAD_SIZE, SIGEV_SIGNAL, SIGEV_THREAD): Likewise.
> (SIGEV_THREAD_ID): Likewise.
> ---
>
>
> I'm assuming those sigevent structure values weren't intended to have
> their definitions included with signals. This patch removes them and
> adds stricter name matching to the regexp.
Good catch. Pushed as c3f95ec.
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-29 22:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-07-22 16:54 bug#21117: [PATCH 4/4] Remove sigevent structure value definitions David Michael
2015-10-29 22:46 ` Ludovic Courtès
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).