* bug in read syntax for arrays
@ 2011-09-05 9:29 Daniel Llorens
2011-09-19 23:50 ` bug#9556: " Andy Wingo
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Llorens @ 2011-09-05 9:29 UTC (permalink / raw)
To: bug-guile
[-- Attachment #1: Type: text/plain, Size: 358 bytes --]
In the latest git,
scheme@(guile-user)> #0(1)
While executing meta-command:
ERROR: Wrong type argument in position 1: #0(1)
The trivial patch attached fixes this problem. However make check passes without the patch, even though arrays.test contains the offending syntax #2((1 2) (3 4) (5 6)). I haven't looked into that.
Regards,
Daniel.
[-- Attachment #2: 0001-Fix-compilation-of-untyped-arrays-of-rank-not-1.patch --]
[-- Type: application/octet-stream, Size: 1135 bytes --]
From 1dc54535b8cfc63606f190971d15072cedd28de7 Mon Sep 17 00:00:00 2001
From: Daniel Llorens <daniel.llorens@bluewin.ch>
Date: Mon, 5 Sep 2011 11:09:08 +0200
Subject: [PATCH] Fix compilation of untyped arrays of rank not 1
* module/language/glil/compile-assembly.scm: vector-fold2 expects vector.
---
module/language/glil/compile-assembly.scm | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/module/language/glil/compile-assembly.scm b/module/language/glil/compile-assembly.scm
index a081822..c76e412 100644
--- a/module/language/glil/compile-assembly.scm
+++ b/module/language/glil/compile-assembly.scm
@@ -856,7 +856,7 @@
(vector-fold2 (lambda (x codes addr)
(receive (subcode addr) (ref-or-dump x i addr)
(values (cons subcode codes) addr)))
- x '() addr)
+ contents '() addr)
(receive (shape addr) (ref-or-dump (array-shape x) i addr)
(values (fold append
(let ((len (vector-length contents)))
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* bug#9556: bug in read syntax for arrays
2011-09-05 9:29 bug in read syntax for arrays Daniel Llorens
@ 2011-09-19 23:50 ` Andy Wingo
2011-09-21 7:44 ` Andy Wingo
0 siblings, 1 reply; 3+ messages in thread
From: Andy Wingo @ 2011-09-19 23:50 UTC (permalink / raw)
To: Daniel Llorens; +Cc: 9556
On Mon 05 Sep 2011 05:29, Daniel Llorens <daniel.llorens@bluewin.ch> writes:
> scheme@(guile-user)> #0(1)
> While executing meta-command:
> ERROR: Wrong type argument in position 1: #0(1)
>
> The trivial patch attached fixes this problem. However make check
> passes without the patch, even though arrays.test contains the
> offending syntax #2((1 2) (3 4) (5 6)). I haven't looked into that.
Thanks for the fix; applied. I think that the deal with the test is
that it's not compiled. It will eventually get fixed when we start
compiling all the tests.
Andy
--
http://wingolog.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#9556: bug in read syntax for arrays
2011-09-19 23:50 ` bug#9556: " Andy Wingo
@ 2011-09-21 7:44 ` Andy Wingo
0 siblings, 0 replies; 3+ messages in thread
From: Andy Wingo @ 2011-09-21 7:44 UTC (permalink / raw)
To: 9556-done
I finally pushed this fix to the repo.
--
http://wingolog.org/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-09-21 7:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-09-05 9:29 bug in read syntax for arrays Daniel Llorens
2011-09-19 23:50 ` bug#9556: " Andy Wingo
2011-09-21 7:44 ` Andy Wingo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).