* bug#36339: generated .pc files leaks build-time LDFLAGS
@ 2019-06-23 9:19 Cyprien Nicolas
2019-06-24 13:17 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Cyprien Nicolas @ 2019-06-23 9:19 UTC (permalink / raw)
To: 36339
Hello,
According to the pkgconfig generated files, Libs.private contains the
build-time LDFLAGS (-Wl,-O1 -Wl,--as-needed).
These flags are private to the way I built guile, and should not affect
packages using guile later.
I have observed this behavior in guile-2.0, 2.2.5 and 2.9.2.
-----8<-----8<-----8<-----8<-----8<-----
Name: GNU Guile
Description: GNU's Ubiquitous Intelligent Language for Extension
Version: 2.0.14
Libs: -L${libdir} -lguile-2.0 -lgc
Libs.private: -lgmp -lltdl -L/usr/lib64/../lib64 -lffi \
-lunistring -Wl,-O1 -Wl,--as-needed -lcrypt -lm \
\
Cflags: -I${pkgincludedir}/2.0 -pthread
----->8----->8----->8----->8----->8-----
Gentoo Bug: https://bugs.gentoo.org/590904
The (1) part seems resolved somehow.
Thanks,
Cyprien
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#36339: generated .pc files leaks build-time LDFLAGS
2019-06-23 9:19 bug#36339: generated .pc files leaks build-time LDFLAGS Cyprien Nicolas
@ 2019-06-24 13:17 ` Ludovic Courtès
2019-07-07 12:45 ` Cyprien Nicolas
0 siblings, 1 reply; 4+ messages in thread
From: Ludovic Courtès @ 2019-06-24 13:17 UTC (permalink / raw)
To: Cyprien Nicolas; +Cc: 36339
[-- Attachment #1: Type: text/plain, Size: 737 bytes --]
Hello,
Cyprien Nicolas <cyprien@nicolas.tf> skribis:
> These flags are private to the way I built guile, and should not
> affect packages using guile later.
>
> I have observed this behavior in guile-2.0, 2.2.5 and 2.9.2.
>
> -----8<-----8<-----8<-----8<-----8<-----
> Name: GNU Guile
> Description: GNU's Ubiquitous Intelligent Language for Extension
> Version: 2.0.14
> Libs: -L${libdir} -lguile-2.0 -lgc
> Libs.private: -lgmp -lltdl -L/usr/lib64/../lib64 -lffi \
> -lunistring -Wl,-O1 -Wl,--as-needed -lcrypt -lm \
> \
>
> Cflags: -I${pkgincludedir}/2.0 -pthread
> ----->8----->8----->8----->8----->8-----
I believe the attached patch should fix it. Could you confirm?
Thanks,
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 291 bytes --]
diff --git a/configure.ac b/configure.ac
index 9073deba0..92966ce34 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1688,7 +1688,7 @@ do
done
GUILE_CFLAGS="$GUILE_CFLAGS $PTHREAD_CFLAGS"
-GUILE_LIBS="$LDFLAGS $LIBS"
+GUILE_LIBS="$LIBS"
AC_SUBST(GUILE_LIBS)
AC_SUBST(GUILE_CFLAGS)
^ permalink raw reply related [flat|nested] 4+ messages in thread
* bug#36339: generated .pc files leaks build-time LDFLAGS
2019-06-24 13:17 ` Ludovic Courtès
@ 2019-07-07 12:45 ` Cyprien Nicolas
2019-07-07 13:09 ` Ludovic Courtès
0 siblings, 1 reply; 4+ messages in thread
From: Cyprien Nicolas @ 2019-07-07 12:45 UTC (permalink / raw)
To: Ludovic Courtès; +Cc: 36339
Hi Ludo,
On 24/06/2019 15:17, Ludovic Courtès wrote:
>
> I believe the attached patch should fix it. Could you confirm?
Yes it does, tested on 2.2.6 and 2.9.2. All arch-dependent binaries have
been built with the right LDFLAGS, and the pkgconfig file looks clean.
Thanks,
Cyprien
^ permalink raw reply [flat|nested] 4+ messages in thread
* bug#36339: generated .pc files leaks build-time LDFLAGS
2019-07-07 12:45 ` Cyprien Nicolas
@ 2019-07-07 13:09 ` Ludovic Courtès
0 siblings, 0 replies; 4+ messages in thread
From: Ludovic Courtès @ 2019-07-07 13:09 UTC (permalink / raw)
To: Cyprien Nicolas; +Cc: 36339-done
Hi Cyprien,
Cyprien Nicolas <cyprien@nicolas.tf> skribis:
> On 24/06/2019 15:17, Ludovic Courtès wrote:
>>
>> I believe the attached patch should fix it. Could you confirm?
>
> Yes it does, tested on 2.2.6 and 2.9.2. All arch-dependent binaries have
> been built with the right LDFLAGS, and the pkgconfig file looks clean.
Awesome. Pushed as a69b567d97f7c9193924c775e1dd86e43a35b8bd to the
‘stable-2.2’ branch.
Thanks!
Ludo’.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-07-07 13:09 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-23 9:19 bug#36339: generated .pc files leaks build-time LDFLAGS Cyprien Nicolas
2019-06-24 13:17 ` Ludovic Courtès
2019-07-07 12:45 ` Cyprien Nicolas
2019-07-07 13:09 ` Ludovic Courtès
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).