* bug#19469: minor nit: (sxml xpath) node-typeof?
@ 2014-12-30 1:57 Matt Wette
2016-02-09 3:58 ` Matt Wette
0 siblings, 1 reply; 3+ messages in thread
From: Matt Wette @ 2014-12-30 1:57 UTC (permalink / raw)
To: 19469
In guile-2.0.11 the following appears in sxml/xpath.scm:
(define (node-typeof? crit)
(lambda (node)
(case crit
((*) (and (pair? node) (not (memq (car node) '(@ *PI*)))))
((*any*) #t)
((*text*) (string? node))
(else
(and (pair? node) (eq? crit (car node))))
)))
Would it be more efficient to swap the "(lambda (node)" and "(case crit" forms?
Matt
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#19469: minor nit: (sxml xpath) node-typeof?
2014-12-30 1:57 bug#19469: minor nit: (sxml xpath) node-typeof? Matt Wette
@ 2016-02-09 3:58 ` Matt Wette
2016-06-22 20:41 ` Andy Wingo
0 siblings, 1 reply; 3+ messages in thread
From: Matt Wette @ 2016-02-09 3:58 UTC (permalink / raw)
To: 19469
I recommend that this bug be closed. The current code is fine and consistent with the rest of the module. — Matt
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#19469: minor nit: (sxml xpath) node-typeof?
2016-02-09 3:58 ` Matt Wette
@ 2016-06-22 20:41 ` Andy Wingo
0 siblings, 0 replies; 3+ messages in thread
From: Andy Wingo @ 2016-06-22 20:41 UTC (permalink / raw)
To: Matt Wette; +Cc: 19469-done
On Tue 09 Feb 2016 04:58, Matt Wette <mwette@alumni.caltech.edu> writes:
> I recommend that this bug be closed. The current code is fine and consistent with the rest of the module. — Matt
OK :) Patches accepted if there are improvements to make :)
A
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-22 20:41 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-12-30 1:57 bug#19469: minor nit: (sxml xpath) node-typeof? Matt Wette
2016-02-09 3:58 ` Matt Wette
2016-06-22 20:41 ` Andy Wingo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).