From: Mike Gran via "Bug reports for GUILE, GNU's Ubiquitous Extension Language" <bug-guile@gnu.org>
To: "64723@debbugs.gnu.org" <64723@debbugs.gnu.org>
Subject: bug#64723: [PATCH] Improve DLL search strategy for load-foreign-library
Date: Thu, 7 Sep 2023 15:33:55 +0000 (UTC) [thread overview]
Message-ID: <1043899963.3392487.1694100835593@mail.yahoo.com> (raw)
In-Reply-To: <vriu7cqwqtd0.fsf@yahoo.com>
> The new non-libltdl foreign library loading algorithm from 3.0.6
> fails to cover common cases regarding how libtool names and installs
> DLL files. Notably, it fails to recognize when libtool has added the
> major version number into the filename itself, such as libfoo-1.dll
> Also, it does not search in binary directories and the PATH for DLL
> files, where libtool is likely to install DLLs.
Hi All-
This is the first of a dozen patches to make Win32 minimally viable
again. This patch specifically removes a regression introduced in 3.0.6
described above.
If I hear no objection, I'm going to rebase and push
in a week or two.
There are only a couple things in here to which one might find
interesting (aka objectionable). One is the renaming of the "#:rename-on-cygwin?
option of `load-foreign-library` to "#:host-type-rename?" to
indicate that it handles both msys and cygwin libraries.
The other is the code itself, which could be a lot shorter
if I pulled in other modules. I'm
never comfortable pulling in modules into other modules in
Guile's core itself, for fear of creating spaghetti. As a consequence,
some of the string handling is comically verbose.
Regards,
Mike Gran
next prev parent reply other threads:[~2023-09-07 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <vriuedl4qtxt.fsf.ref@yahoo.com>
2023-07-19 6:47 ` bug#64723: load-foreign-library has incomplete support for libtool-generated DLLs Michael Gran via Bug reports for GUILE, GNU's Ubiquitous Extension Language
2023-06-02 23:28 ` bug#64723: [PATCH] Improve DLL search strategy for load-foreign-library Michael Gran via Bug reports for GUILE, GNU's Ubiquitous Extension Language
2023-09-07 15:33 ` Mike Gran via Bug reports for GUILE, GNU's Ubiquitous Extension Language [this message]
2023-09-09 5:44 ` Janneke Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1043899963.3392487.1694100835593@mail.yahoo.com \
--to=bug-guile@gnu.org \
--cc=64723@debbugs.gnu.org \
--cc=spk121@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).