From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mike Gran via "Bug reports for GUILE, GNU's Ubiquitous Extension Language" Newsgroups: gmane.lisp.guile.bugs Subject: bug#64723: [PATCH] Improve DLL search strategy for load-foreign-library Date: Thu, 7 Sep 2023 15:33:55 +0000 (UTC) Message-ID: <1043899963.3392487.1694100835593@mail.yahoo.com> References: Reply-To: Mike Gran Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14725"; mail-complaints-to="usenet@ciao.gmane.io" To: "64723@debbugs.gnu.org" <64723@debbugs.gnu.org> Original-X-From: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Thu Sep 07 17:37:24 2023 Return-path: Envelope-to: guile-bugs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qeH4N-0003Xj-Q7 for guile-bugs@m.gmane-mx.org; Thu, 07 Sep 2023 17:37:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qeH43-0001uP-NT; Thu, 07 Sep 2023 11:37:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qeH40-0001uG-Q4 for bug-guile@gnu.org; Thu, 07 Sep 2023 11:37:01 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qeH40-0007g2-Ft for bug-guile@gnu.org; Thu, 07 Sep 2023 11:37:00 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qeH41-0005Kj-T6 for bug-guile@gnu.org; Thu, 07 Sep 2023 11:37:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mike Gran Original-Sender: "Debbugs-submit" Resent-CC: bug-guile@gnu.org Resent-Date: Thu, 07 Sep 2023 15:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64723 X-GNU-PR-Package: guile Original-Received: via spool by 64723-submit@debbugs.gnu.org id=B64723.169410101220486 (code B ref 64723); Thu, 07 Sep 2023 15:37:01 +0000 Original-Received: (at 64723) by debbugs.gnu.org; 7 Sep 2023 15:36:52 +0000 Original-Received: from localhost ([127.0.0.1]:41056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeH3s-0005KL-8v for submit@debbugs.gnu.org; Thu, 07 Sep 2023 11:36:52 -0400 Original-Received: from sonic310-14.consmr.mail.bf2.yahoo.com ([74.6.135.124]:42507) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qeH3n-0005K5-MS for 64723@debbugs.gnu.org; Thu, 07 Sep 2023 11:36:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694100989; bh=/Pw3MqP4EhruiFsJqLHEQX2bZRuaZ6R6fhuXwb8L9QE=; h=Date:From:To:In-Reply-To:References:Subject:From:Subject:Reply-To; b=emaGhnJKYr0RGPtdzg4rO6TKm0AfxWEBPk83X4oCX2MRGXGvXGXyi6vV5p/8qpAICLOtuftgMey6wcvZyaLMsT4zhvO+Q8UsK0Dn6qrPUYLYRi0ZU+E9g6IR65aoYwIKHAyCHY5xnl2MsHEUF7XqphJAOa+Fw7OXY+RjbUjGg+yNk60tqWvHOeuMFy8ig+btwBn7mRzRpHY/NOqgAHzgJlh4QNmRPSorzLp45CwX2YlFvSNq8qp0P0UOA7UV86Rm1e5u4YATZEKAhmQ7HkSJIhhY3dFeLtrzIK5mTB319rzggsI+0FtdR7AFnok3ndLjVdTBoITjT9d7rvrai3jbWQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1694100989; bh=bqeE0x66GEzrv/B3de6tlRHXJ+D4+hUSaBpoYAzLvcv=; h=X-Sonic-MF:Date:From:To:Subject:From:Subject; b=mIvn/p2aZZ3ZpynM3usW/1UBQcA+wGyYJiIyrLpyl6AMJPgNIVCYJVNsfXBMiLnYiGLJkImedaNOuZKTPrHBshB5Rc4ii6SiGG/HZLw0r7fewUpQE6O1HqBUQFeEQjhgx7fTLokILbGo/QoGQ3RyWiujWVAl98wfFDav7Q5/x6F1yO2dE98RRCfgkiTwMGTdMuFodsNNw4ej5KPcFE+o78xw4E3qd6wLrzvxZks/m73UpfAoyOZZgkI2VZnaRMj+DXKanIszgzOiUIyTH6yHSjxvklhXL3KX0RI9eVS7Yxm00BQRpJ8qwkhhwjaw9AhovA0hGyX2hmUQag8CeY90iw== X-YMail-OSG: ljmxLKAVM1mn1tMXnWLa.RTr5ok0oLbsyO.WTjfO9LzhlBGDZ1ll4OFghYoex2. 0tdlUB72S.iBQ8kfaST.H7Ou98onXO0rkgobe7DyG1aGWL6ITVqE4D69SNITwV76pn7EHVvh56bt 1LHjxWG8sPsodBlAoozp2tL_nDCJTV5dvjcqJyTJnzclFsY.VvExqowJqwnmZjVUloZ5mzVGfgaL nkkBKNL5bd_r6X2fRdXhJ9fIALTTcw3QgoAkBu3hKGg8dw7GFAWYF3QVWz0A6Jyi_wEbNIEox9Tq H4E1mX9bAalBENh_E.hrcbnRvGJXnKJ8klOo.YSGrQfAKoNCF4mj.PqhTIZYkCi4iQPbnu3vxWGp Ncy1ojMKc0GMq4StWRL2.OLojMKJFzY6j0oo62ZhzyfYultv5sbXesOwfbBR5XjITOK2TkqfpnXB 2NUi7f.1.qdbwF9zjYBA8ZkBsFnP5StFRCTq1F8urscGK2n0dLl94ZyZgLV6BOjfuRNyf5mWKCyY QzX.pGeWPwT2gMDMPJo1EhlqcaOnsrdr9.hQEYpn1iek9hDUetfAoWr89ibyWCuxB3F8A4aoHL3v 0EmsoruV6r2uw7Jret4e66A0P5ijihbGoi_fIkKAmY2u5fXkctP04.yWfZkJm9vASSxf0E9JegA. 9XA9IqEVXjOspwI2tsjGldqLeAeLbNgoIHN4wVMyhZQcfmhvCwiX9jF_qHyUEe7KL3L7.36p9UBs .EPUOhuKGQvpVciRG6ownpP5v55767weZzYOHIV5K8s4lRXt04a7YbvNPns1VXUxykBZiHcst5.F YxgpeO_QK43Qvk9eovkFA2Wj_kn.dNqN6dv.oTyToh X-Sonic-MF: X-Sonic-ID: 763f325e-a732-49c3-9c71-1578e3ffa1c6 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic310.consmr.mail.bf2.yahoo.com with HTTP; Thu, 7 Sep 2023 15:36:29 +0000 In-Reply-To: X-Mailer: WebService/1.1.21763 YMailNorrin X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-guile@gnu.org List-Id: "Bug reports for GUILE, GNU's Ubiquitous Extension Language" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Original-Sender: bug-guile-bounces+guile-bugs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.bugs:10657 Archived-At: > The new non-libltdl foreign library loading algorithm from 3.0.6 > fails to cover common cases regarding how libtool names and installs > DLL files.=C2=A0 Notably, it fails to recognize when libtool has added th= e > major version number into the filename itself, such as libfoo-1.dll > Also, it does not search in binary directories and the PATH for DLL > files, where libtool is likely to install DLLs. Hi All- This is the first of a dozen patches to make Win32 minimally viable again. This patch specifically removes a regression introduced in 3.0.6 described above. If I hear no objection, I'm going to rebase and push in a week or two. There are only a couple things in here to which one might find interesting (aka objectionable).=C2=A0 One is the renaming of the "#:rename= -on-cygwin? option of `load-foreign-library` to "#:host-type-rename?" to indicate that it handles both msys and cygwin libraries. The other is the code itself, which could be a lot shorter if I pulled in other modules. I'm never comfortable pulling in modules into other modules in Guile's core itself, for fear of creating spaghetti.=C2=A0 As a consequence= , some of the string handling is comically verbose. Regards, Mike Gran