all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eason Huang <aqua0210@foxmail.com>
To: "João Távora" <joaotavora@gmail.com>
Cc: casouri@gmail.com, "Stefan Monnier" <monnier@iro.umontreal.ca>,
	60087@debbugs.gnu.org, "Daniel Martín" <mardani29@yahoo.es>
Subject: bug#60087: 29.0.60; c++-ts-mode conflict with electric-pair-mode
Date: Thu, 29 Dec 2022 14:10:13 +0800	[thread overview]
Message-ID: <tencent_D81AD826969CD54B47C91852C1461838EA06@qq.com> (raw)
In-Reply-To: <tencent_F3231B12E05B6B139BE872442F7E251F4808@qq.com>

Hi all,

I can confirmed that the latest commit (909091d7578b7225601b202fb9257dedae879e9a)
 of Emacs-29 have been fix this bug#60087,  and `show-paren-mode` also get the expected result
 when c++-ts-mode enabled.

I think we can close this bug now.

----

Eason Huang

> 2022年12月27日 17:03,Eason Huang <aqua0210@foxmail.com> 写道:
> 
> João Távora <joaotavora@gmail.com> writes:
> 
>> On Thu, Dec 15, 2022 at 9:34 PM Daniel Martín <mardani29@yahoo.es> wrote:
> 
>> Does the following patch solve this issue and bug#60049?
> 
>> diff --git a/lisp/progmodes/c-ts-mode.el b/lisp/progmodes/c-ts-mode.el
>> index ff2ff63fd8..11b2b9408c 100644
>> --- a/lisp/progmodes/c-ts-mode.el
>> +++ b/lisp/progmodes/c-ts-mode.el
>> @@ -86,8 +86,8 @@ c-ts-mode--syntax-table
>> (defvar c++-ts-mode--syntax-table
>>  (let ((table (make-syntax-table c-ts-mode--syntax-table)))
>>    ;; Template delimiters.
>> -    (modify-syntax-entry ?<  "("     table)
>> -    (modify-syntax-entry ?>  ")"     table)
>> +    (modify-syntax-entry ?<  "(>"     table)
>> +    (modify-syntax-entry ?>  ")<"     table)
>>    table)
>>  "Syntax table for `c++-ts-mode'.")
> 
> Hi Daniel,
> 
> Sorry for the delay feedback.
> 
> I tried your patch and it fixs bug#60049, but I just notice that `show-paren-mode` don't
> play well with c++-ts-mode too (before and after this patch).
> 
> with the code snippet as below:
> 
> ```
> #include <iostream>
> 
> int main (){
>    std::cout << "Test" << '\n';
>    return 0;
> }
> ```
> 
> With `show-paren-mode` enabled, then put cursor after the '}', the last
> '<' will be matched and highlighted, the expected match is the '{'.
> 
> I hope this information will help you to understand the issue.
> 






  reply	other threads:[~2022-12-29  6:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-15 11:17 bug#60087: 29.0.60; c++-ts-mode conflict with electric-pair-mode Eason Huang
2022-12-15 12:24 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-15 13:10   ` João Távora
2022-12-15 21:34     ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-12-15 21:43       ` João Távora
2022-12-27  9:03         ` Eason Huang
2022-12-29  6:10           ` Eason Huang [this message]
2022-12-29  6:33             ` Eli Zaretskii
2022-12-29  8:43             ` Yuan Fu
2022-12-29  9:07               ` João Távora
2022-12-15 13:05 ` João Távora
2022-12-15 13:21   ` Eason Huang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=tencent_D81AD826969CD54B47C91852C1461838EA06@qq.com \
    --to=aqua0210@foxmail.com \
    --cc=60087@debbugs.gnu.org \
    --cc=casouri@gmail.com \
    --cc=joaotavora@gmail.com \
    --cc=mardani29@yahoo.es \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.