From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eason Huang Newsgroups: gmane.emacs.bugs Subject: bug#60087: 29.0.60; c++-ts-mode conflict with electric-pair-mode Date: Thu, 29 Dec 2022 14:10:13 +0800 Message-ID: References: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.300.101.1.3\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18017"; mail-complaints-to="usenet@ciao.gmane.io" Cc: casouri@gmail.com, Stefan Monnier , 60087@debbugs.gnu.org, Daniel =?UTF-8?Q?Mart=C3=ADn?= To: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 29 07:11:11 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAm8F-0004Wp-7D for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Dec 2022 07:11:11 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAm87-0006IK-Ma; Thu, 29 Dec 2022 01:11:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAm86-0006IB-HZ for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2022 01:11:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAm86-0007Sk-8z for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2022 01:11:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAm86-0005ax-4Y for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2022 01:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eason Huang Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Dec 2022 06:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60087 X-GNU-PR-Package: emacs Original-Received: via spool by 60087-submit@debbugs.gnu.org id=B60087.167229424921486 (code B ref 60087); Thu, 29 Dec 2022 06:11:02 +0000 Original-Received: (at 60087) by debbugs.gnu.org; 29 Dec 2022 06:10:49 +0000 Original-Received: from localhost ([127.0.0.1]:59149 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAm7t-0005aU-1o for submit@debbugs.gnu.org; Thu, 29 Dec 2022 01:10:49 -0500 Original-Received: from out162-62-57-252.mail.qq.com ([162.62.57.252]:35409) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAm7n-0005a5-2j for 60087@debbugs.gnu.org; Thu, 29 Dec 2022 01:10:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=foxmail.com; s=s201512; t=1672294232; bh=j8hMJEnDnvRbLSaP+2T980YIkCWkK6EW7PciXyKTvCE=; h=Subject:From:In-Reply-To:Date:Cc:References:To; b=GoXquwaAuVlZ/Pj5M/UEaDU9CPqpJq+StfKr/UtkeF7wX1nNhznpepxrC1usOnYsR eGJppjIta9mICX0SXky7UJ3lRnycKRexr4oxdOcgoJUdqQ6fSegsFQUNZt7RSgi8JU MBkgbUSYWxYnjWdffBN7/nET7dFt30PXc2MvQ40M= Original-Received: from smtpclient.apple ([2402:d0c0:2:2e58::1]) by newxmesmtplogicsvrszc1-0.qq.com (NewEsmtp) with SMTP id 29A006B1; Thu, 29 Dec 2022 14:10:26 +0800 X-QQ-mid: xmsmtpt1672294226td8j3sau0 X-QQ-XMAILINFO: NfHsM/dq2nWIEpgp0dehAOA+PSqcCgAwYR0OKBGBVKc8DsKYXoC+MKYYx9beDV 6BUnQn3So0rOX/allTzy/oiC7MrVMIi4rD/o9RSXI7ZnYDsmd07mwK9P0zvU/ET8OVh/R/UKqnes lAJM4E14gORCPk146ikc8g2S2WtknvtZcO6dVI7EUUmwey7VqrpvC7sPfBCSzha4qMRGGDEPitCY Zv8bGXV5oc8Sn8ZFYN4aAsiL0wwo9cj1Dao8E0+L/Vl9T7+UHZ7aa/UrkiCcWicpjoHoRYWUqR9O jgEn32K7fqTpK4sTwmQE0jefgWHaA+mDrwr/CYgNPJNry20yo4Y6xLYSdcp8DRFmLKwmKHHfgyvY V1cV667YWxVeoYTB44gzDano58lVQYPi/4CNbkAHaXEZm2L+psVgly8PvgHuoddAzzR3Xlnx797k HMsHd9YL1Za5bQlkvB6gN4LU24Ype9aebL4iZ0tEZjG16nFBjOKSVIfhiIz9QX14Hj9eTeqHbMAt GFJUKSCWdIfqqzMyA4W4gZaPtMxo/zDQ9LHitIADdYMkjSAQIW7YyhMCJWHNhI6LokpoZWSdWnM5 V+LJqeSrLuSi9l/QtUMCX33cO41q++vCcjRe9mqclIQDcCUHrzogonJLdWEpTdxt4PCYO6a7/lY9 N0P/RMqA5UXt3qMkXNaxViFvMcuHYB13x8+lgr8wN2EDScP8XHNB4D4T8r4Gvn7lHkmNDOvJ9Hv7 bHh78+Da1YXRrZ7eUdC8aSjxZ/fMb4WsYoEANVYoqK7M4clCBAdI7tpiGhL+meXyObSBjhglh6vX 9KmpMGSvEhFSwbJeG6hmaY4jaoTaHVfya8pDxSyb In-Reply-To: X-OQ-MSGID: <607E1FCB-0356-4D21-8EA4-AC2255D15467@foxmail.com> X-Mailer: Apple Mail (2.3731.300.101.1.3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252009 Archived-At: Hi all, I can confirmed that the latest commit = (909091d7578b7225601b202fb9257dedae879e9a) of Emacs-29 have been fix this bug#60087, and `show-paren-mode` also = get the expected result when c++-ts-mode enabled. I think we can close this bug now. ---- Eason Huang > 2022=E5=B9=B412=E6=9C=8827=E6=97=A5 17:03=EF=BC=8CEason Huang = =E5=86=99=E9=81=93=EF=BC=9A >=20 > Jo=C3=A3o T=C3=A1vora writes: >=20 >> On Thu, Dec 15, 2022 at 9:34 PM Daniel Mart=C3=ADn = wrote: >=20 >> Does the following patch solve this issue and bug#60049? >=20 >> diff --git a/lisp/progmodes/c-ts-mode.el = b/lisp/progmodes/c-ts-mode.el >> index ff2ff63fd8..11b2b9408c 100644 >> --- a/lisp/progmodes/c-ts-mode.el >> +++ b/lisp/progmodes/c-ts-mode.el >> @@ -86,8 +86,8 @@ c-ts-mode--syntax-table >> (defvar c++-ts-mode--syntax-table >> (let ((table (make-syntax-table c-ts-mode--syntax-table))) >> ;; Template delimiters. >> - (modify-syntax-entry ?< "(" table) >> - (modify-syntax-entry ?> ")" table) >> + (modify-syntax-entry ?< "(>" table) >> + (modify-syntax-entry ?> ")<" table) >> table) >> "Syntax table for `c++-ts-mode'.") >=20 > Hi Daniel, >=20 > Sorry for the delay feedback. >=20 > I tried your patch and it fixs bug#60049, but I just notice that = `show-paren-mode` don't > play well with c++-ts-mode too (before and after this patch). >=20 > with the code snippet as below: >=20 > ``` > #include >=20 > int main (){ > std::cout << "Test" << '\n'; > return 0; > } > ``` >=20 > With `show-paren-mode` enabled, then put cursor after the '}', the = last > '<' will be matched and highlighted, the expected match is the '{'. >=20 > I hope this information will help you to understand the issue. >=20