From: Robert Pluim <rpluim@gmail.com>
To: Michael Albinus <michael.albinus@gmx.de>
Cc: Tino Calancha <tino.calancha@gmail.com>, 39138@debbugs.gnu.org
Subject: bug#39138: 28.0.50; Add variables for shell command output buffer names
Date: Wed, 15 Jan 2020 09:03:05 +0100 [thread overview]
Message-ID: <m2lfq9qh8m.fsf@gmail.com> (raw)
In-Reply-To: <87lfq9d5hn.fsf@gmx.de> (Michael Albinus's message of "Tue, 14 Jan 2020 23:43:00 +0100")
>>>>> On Tue, 14 Jan 2020 23:43:00 +0100, Michael Albinus <michael.albinus@gmx.de> said:
Michael> Tino Calancha <tino.calancha@gmail.com> writes:
>> --- a/lisp/net/tramp.el
>> +++ b/lisp/net/tramp.el
>> @@ -3658,8 +3658,8 @@ tramp-handle-shell-command
>> (current-buffer))
>> (t (get-buffer-create
>> (if asynchronous
>> - "*Async Shell Command*"
>> - "*Shell Command Output*")))))
>> + shell-command-buffer-name-async
>> + shell-command-buffer-name)))))
>> (error-buffer
>> (cond
>> ((bufferp error-buffer) error-buffer)
Michael> OK for me. However, I will tweak this a little bit once committed, in
Michael> order to keep Tramp's backward compatibility. Likely like this:
Michael> (or (bound-and-true-p shell-command-buffer-name-async) "*Async Shell Command*")
Michael> etc. Plus a comment, which Emacs version has introduced the variables,
Michael> in order to know when this compatibility hack can be removed.
Tino, would it be possible to add text back in the manual saying what
the default values of these new variables are? People reading it
inside Emacs can obviously just inspect their values, but not everyone
reads inside Emacs.
Robert
next prev parent reply other threads:[~2020-01-15 8:03 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-14 21:31 bug#39138: 28.0.50; Add variables for shell command output buffer names Tino Calancha
2020-01-14 22:43 ` Michael Albinus
2020-01-15 8:03 ` Robert Pluim [this message]
2020-01-15 16:11 ` Eli Zaretskii
2020-01-15 19:41 ` Tino Calancha
2020-01-15 23:09 ` Juri Linkov
2020-02-25 13:12 ` Michael Albinus
2020-05-19 4:08 ` Stefan Kangas
2020-05-19 14:09 ` Eli Zaretskii
2020-05-19 14:16 ` Stefan Kangas
2020-05-19 15:26 ` Tino Calancha
2020-08-09 12:19 ` Lars Ingebrigtsen
2020-08-09 23:18 ` Juri Linkov
2020-08-10 10:45 ` Lars Ingebrigtsen
2020-08-10 23:59 ` Juri Linkov
2020-08-11 11:16 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m2lfq9qh8m.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=39138@debbugs.gnu.org \
--cc=michael.albinus@gmx.de \
--cc=tino.calancha@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.