From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.bugs Subject: bug#39138: 28.0.50; Add variables for shell command output buffer names Date: Wed, 15 Jan 2020 09:03:05 +0100 Message-ID: References: <878sm9u3m1.fsf@calancha-pc.dy.bbexcite.jp> <87lfq9d5hn.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="46347"; mail-complaints-to="usenet@blaine.gmane.org" Cc: Tino Calancha , 39138@debbugs.gnu.org To: Michael Albinus Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jan 15 09:04:27 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1irdf8-000Bh8-Ih for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 09:04:26 +0100 Original-Received: from localhost ([::1]:50750 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irdf7-0003dy-2B for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 15 Jan 2020 03:04:25 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:42764) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1irdeo-0003dp-MN for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 03:04:10 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1irdek-0004Xr-Mg for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 03:04:06 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:56488) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1irdek-0004Xc-JM for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 03:04:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1irdek-0001Q9-F2 for bug-gnu-emacs@gnu.org; Wed, 15 Jan 2020 03:04:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Robert Pluim Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 15 Jan 2020 08:04:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 39138 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 39138-submit@debbugs.gnu.org id=B39138.15790754045409 (code B ref 39138); Wed, 15 Jan 2020 08:04:02 +0000 Original-Received: (at 39138) by debbugs.gnu.org; 15 Jan 2020 08:03:24 +0000 Original-Received: from localhost ([127.0.0.1]:34228 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irde4-0001P7-C2 for submit@debbugs.gnu.org; Wed, 15 Jan 2020 03:03:24 -0500 Original-Received: from mail-wm1-f46.google.com ([209.85.128.46]:36531) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1irddy-0001Ok-GP for 39138@debbugs.gnu.org; Wed, 15 Jan 2020 03:03:19 -0500 Original-Received: by mail-wm1-f46.google.com with SMTP id p17so16705838wma.1 for <39138@debbugs.gnu.org>; Wed, 15 Jan 2020 00:03:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :mime-version; bh=gVupE+yJ23NcWTAfng/u6MEh2+1UEYY8Kht7sWzovKc=; b=nXVdN7Ap4O5x8URocrW1BQWaEc5eXWFnYNr6emdd/JuCOVDMHAK96Ap7WA78xs0lLE DGQd0/ZOQc34yrpBBV5oKLtjDy6K0ylChuG4v/XS3zmskhlISkGogI2y1+Cd1zDTV4eI xRa2ij2HVsIAKxB9PezYokfqIjlADsWSOtR9M6XUKWWI3foS/eLVsWUq5+1kAgS8XX50 Yq0PWi5cyMPwLx3RJzjGiiKbulSQtAg/BYDiLsfZ+FNP0LZI26Bf2tUFUJq4oWElj1Rn TWZG4mAabp2zTEhe3mJjNKHn76e65EsAftJGYJknZFU5Fx5jJRwtBtRa2JFOM+wySMpa czYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:mime-version; bh=gVupE+yJ23NcWTAfng/u6MEh2+1UEYY8Kht7sWzovKc=; b=UGZ4Y1KKzCGS+mWknX26x7fGMQCw/Gm/0mu3CH5jI5i8dwIQfKfXKsWQpJ+qAXMOhi MIBr+QaW4Npl+SV4v9DGKhX0pFosrr9Ub5GsjN6fB2RHGVCKISq3JCWKYyS3yRH75QFs kEoIO7zcX1OV8RrxcKNGctbIpJZi/tqNh5vy2UuRYwl7LzRdl1yJzuEMBaa2p33C3YuG rTAUbjLwjLj1eiwK0iaPLglnhe+Z319F+I8QHwYKClr270f+8PCGyJeeXWMpTmXJEBqT L4e4OY4B8sL7IDQyznMvf2qcIfXn4jtqW1xqM2EJO8FoJbipkNlIVJZN5P8tDP/Uzgzo vFqw== X-Gm-Message-State: APjAAAUiClvvXmUelLbI3wjI8+ocVpKzaEeK2S/b0GeZ41sQVvrIxqmb y03K1NOyMvudIj00Mpe1SPQVoGwm9Nw= X-Google-Smtp-Source: APXvYqytPwG2QhdGeJAsI8hwMuKAMpvtL4QlOEDukbOsRJndREyrX09SH9QmsDaafWQ6nedm0xVw0w== X-Received: by 2002:a1c:44d:: with SMTP id 74mr32809623wme.53.1579075388339; Wed, 15 Jan 2020 00:03:08 -0800 (PST) Original-Received: from rpluim-mac ([149.5.228.1]) by smtp.gmail.com with ESMTPSA id l19sm21940086wmj.12.2020.01.15.00.03.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Jan 2020 00:03:07 -0800 (PST) In-Reply-To: <87lfq9d5hn.fsf@gmx.de> (Michael Albinus's message of "Tue, 14 Jan 2020 23:43:00 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:174619 Archived-At: >>>>> On Tue, 14 Jan 2020 23:43:00 +0100, Michael Albinus said: Michael> Tino Calancha writes: >> --- a/lisp/net/tramp.el >> +++ b/lisp/net/tramp.el >> @@ -3658,8 +3658,8 @@ tramp-handle-shell-command >> (current-buffer)) >> (t (get-buffer-create >> (if asynchronous >> - "*Async Shell Command*" >> - "*Shell Command Output*"))))) >> + shell-command-buffer-name-async >> + shell-command-buffer-name))))) >> (error-buffer >> (cond >> ((bufferp error-buffer) error-buffer) Michael> OK for me. However, I will tweak this a little bit once committed, in Michael> order to keep Tramp's backward compatibility. Likely like this: Michael> (or (bound-and-true-p shell-command-buffer-name-async) "*Async Shell Command*") Michael> etc. Plus a comment, which Emacs version has introduced the variables, Michael> in order to know when this compatibility hack can be removed. Tino, would it be possible to add text back in the manual saying what the default values of these new variables are? People reading it inside Emacs can obviously just inspect their values, but not everyone reads inside Emacs. Robert