* bug#61764: 29.0.60; eglot show incomplete inlay hints
@ 2023-02-24 17:10 Kai Ma
0 siblings, 0 replies; only message in thread
From: Kai Ma @ 2023-02-24 17:10 UTC (permalink / raw)
To: 61764
The display of some inlay hints are not complete. For example, in a
Rust source file:
let v = vec![1i32];
The expected display is:
let v: Vec<i32> = ...;
However, the current eglot (commit 55d29c9bacb in branch emacs-29) only
shows the semicolon:
let v: = ...;
I found that the inlay hint returned by rust-analyzer is something like:
([(:value ": ") (:value "Vec" :location ...) (:value "<i32>")])
And I can confirm that by making the following change, the inlay hints
from rust-analyzer will be displayed correctly.
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -3549,7 +3549,7 @@ eglot--update-hints-1
(left-pad (and paddingLeft (not (memq (char-before) '(32 9)))))
(right-pad (and paddingRight (not (memq (char-after) '(32 9)))))
(text (if (stringp label)
- label (plist-get (elt label 0) :value))))
+ label (mapconcat (lambda (plist) (plist-get plist :value)) label))))
(overlay-put ov 'before-string
(propertize
(concat (and left-pad " ") text (and right-pad " "))
According to the LSP spec [1], the intention of this design is to
support the use case where a LSP client shows different information for
each part. Therefore, I believe this (concatenation) is the correct
thing to do, regardless of whether eglot supports hovering.
[1] https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#inlayHint
Kai
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2023-02-24 17:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-02-24 17:10 bug#61764: 29.0.60; eglot show incomplete inlay hints Kai Ma
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.