Re: [ELPA] New package: activities

[Eshel Yaron <me@eshelyaron.com>]

Hello,

Adam Porter <adam@alphapapa.net> writes:

> Hi,
>
> I'd like to add a new package to ELPA, activities.el.  It's hosted at:
>
>   https://github.com/alphapapa/activities.el

Look interesting!

FWIW, I think a spot a small mistake in `activities-completing-read`:
passing the value of the history variable to `completing-read` instead
of the variable name.  Also, it seems like the commands that use this
function expect an existing "activity", so would it make sense to accept
only matching inputs?  That is, making the following change:

diff --git a/activities.el b/activities.el
index 60bbcaf..8ea687b 100644
--- a/activities.el
+++ b/activities.el
@@ -638,7 +638,7 @@ (cl-defun activities-completing-read
   "Return an activity read with completion from ACTIVITIES.
 PROMPT is passed to `completing-read', which see."
   (let* ((names (activities-names activities))
-         (name (completing-read prompt names nil nil nil activities-completing-read-history)))
+         (name (completing-read prompt names nil t nil 'activities-completing-read-history)))
     (or (map-elt activities-activities name)
         (make-activities-activity :name name))))