From: Adam Porter <adam@alphapapa.net>
To: me@eshelyaron.com
Cc: adam@alphapapa.net, emacs-devel@gnu.org
Subject: Re: [ELPA] New package: activities
Date: Fri, 26 Jan 2024 04:48:51 -0600 [thread overview]
Message-ID: <944e8248-e846-42df-b4c7-4dbdc6c8a7ed@alphapapa.net> (raw)
In-Reply-To: <m134ukbix8.fsf@dazzs-mbp.home>
Hi Eshel,
> FWIW, I think a spot a small mistake in `activities-completing-read`:
> passing the value of the history variable to `completing-read` instead
> of the variable name. Also, it seems like the commands that use this
> function expect an existing "activity", so would it make sense to accept
> only matching inputs? That is, making the following change:
Thanks for catching those. I pushed a fix and mentioned you in the
commit message.
--Adam
next prev parent reply other threads:[~2024-01-26 10:48 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-26 0:59 [ELPA] New package: activities Adam Porter
2024-01-26 7:33 ` Philip Kaludercic
2024-01-26 10:36 ` Adam Porter
2024-01-29 19:50 ` Adam Porter
2024-01-30 7:16 ` Philip Kaludercic
2024-01-30 7:43 ` Adam Porter
2024-01-26 7:45 ` Eli Zaretskii
2024-01-26 10:42 ` Adam Porter
2024-01-26 12:32 ` Eli Zaretskii
2024-01-26 21:59 ` Adam Porter
2024-01-27 7:08 ` Eli Zaretskii
2024-01-27 8:46 ` Adam Porter
2024-01-27 14:53 ` Eric S Fraga
2024-01-27 15:32 ` Eli Zaretskii
2024-01-27 16:14 ` Sergey Organov
2024-01-28 11:25 ` Eric S Fraga
2024-01-29 10:45 ` Sergey Organov
2024-01-29 13:03 ` Philip Kaludercic
2024-01-29 22:23 ` Sergey Organov
2024-01-29 15:29 ` Fraga, Eric
2024-01-26 8:25 ` Eshel Yaron
2024-01-26 10:48 ` Adam Porter [this message]
2024-01-29 21:48 ` JD Smith
2024-01-30 0:08 ` Chris Van Dusen
2024-01-30 0:24 ` Adam Porter
2024-02-01 3:49 ` Richard Stallman
2024-01-30 2:50 ` JD Smith
-- strict thread matches above, loose matches on Subject: below --
2024-01-27 19:20 Drew Adams
2024-02-01 5:33 Joseph Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=944e8248-e846-42df-b4c7-4dbdc6c8a7ed@alphapapa.net \
--to=adam@alphapapa.net \
--cc=emacs-devel@gnu.org \
--cc=me@eshelyaron.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.