From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Philip Kaludercic <philipk@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: Removing packages from archive-contents if removed from elpa-packages
Date: Mon, 31 Oct 2022 08:11:59 -0400 [thread overview]
Message-ID: <jwvtu3k19yk.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <878rkwe3fv.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 31 Oct 2022 09:40:36 +0000")
Philip Kaludercic [2022-10-31 09:40:36] wrote:
> there is at least one broken package on NonGNU ELPA
> (color-theme-tangotango) that was added, then removed as dependencies
> were missing, but it remained in the archive because it was added to the
> archive-contents file. The following patch would make sure that any
> package not listed in elpa-packages is also remove from
> archive-contents:
Thanks, but I don't think `elpaa--update-archive-contents` is the right
place for that. This can be called N times for a given invocation of
`elpaa-batch-make-all-packages`.
Why not call a dedicated function from `elpaa-batch-make-all-packages`
(i.e. alongside the call to `elpaa--publish-package-specs`)?
> It might be a good idea to cache the interpretation of elpa-packages, so
> I would also suggest the following:
Not sure it's worth the trouble: the way the code is written, it should
be called only once per Emacs session in the majority of cases, no?
> 1. This does not remove any tarballs. It wouldn't be hard to do, but I
> am not sure if there would be any unintended side effects of doing
> so -- at least immediately.
I think we should keep the old HTML page and tarballs.
> 2. There are functioning packages on NonGNU ELPA like haskell-mode that
> were also added to elpa-packages then removed, and still linger in
> the archive without being updated. This would get rid of those too,
> which might not be a good idea.
Indeed, `haskell-mode` should be re-added to `elpa-packages`
because IIRC it's still actively depended-upon (by GNU ELPA's `hcel`).
Stefan
next prev parent reply other threads:[~2022-10-31 12:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 9:40 Removing packages from archive-contents if removed from elpa-packages Philip Kaludercic
2022-10-31 12:11 ` Stefan Monnier [this message]
2022-10-31 14:25 ` Philip Kaludercic
2022-10-31 14:47 ` Stefan Kangas
2022-10-31 15:10 ` Philip Kaludercic
2022-10-31 16:06 ` Philip Kaludercic
2022-10-31 17:53 ` Stefan Monnier
2022-11-01 10:42 ` Philip Kaludercic
2022-11-02 2:02 ` Stefan Monnier
2022-11-02 6:59 ` Philip Kaludercic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvtu3k19yk.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=philipk@posteo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.