From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Removing packages from archive-contents if removed from elpa-packages Date: Mon, 31 Oct 2022 08:11:59 -0400 Message-ID: References: <878rkwe3fv.fsf@posteo.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5332"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Philip Kaludercic Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Oct 31 13:12:56 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1opTew-0001Cc-V5 for ged-emacs-devel@m.gmane-mx.org; Mon, 31 Oct 2022 13:12:55 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1opTeI-0006br-FM; Mon, 31 Oct 2022 08:12:14 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opTeA-0006ah-MH for emacs-devel@gnu.org; Mon, 31 Oct 2022 08:12:07 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1opTe8-0004Yv-QQ for emacs-devel@gnu.org; Mon, 31 Oct 2022 08:12:06 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 8E05644134A; Mon, 31 Oct 2022 08:12:02 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id D6E5244131A; Mon, 31 Oct 2022 08:12:00 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1667218320; bh=3JLbFh+em/MNFj+QmMedkhl5YrefjlBM3wAF9DivyPs=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=WraHL6q6inbOBBO3SDigooehlI9aFPHnB02k/rLXf2tPq50rncrxGECtmf++IRc9F LD6NJxcj72oG46eAQjZldaWs6tZhNWIGU7WIXTEJHrW7Fcaz1c6gcHlVVFiD8/fLyf dHn537KABAWAmT50ZYz0JNP1PsJAyft/MLVZHPFqpLv6uLjEHehNT1gC2k0yZhdnx8 b21MEQuQePKJaA5U6Y5c6HbqUtjdh5ztln+KtZDe384nmF+lmadLicyYr9zzZ0mCp0 dvfHRCP1Qczf70H8xjAqauZ4AwiMLurfcAc5AaftiDfrDRar+rTnJqHuLSoz+afeA+ 0ZNjnqekSeLBQ== Original-Received: from pastel (65-110-220-202.cpe.pppoe.ca [65.110.220.202]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id AC888120409; Mon, 31 Oct 2022 08:12:00 -0400 (EDT) In-Reply-To: <878rkwe3fv.fsf@posteo.net> (Philip Kaludercic's message of "Mon, 31 Oct 2022 09:40:36 +0000") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: "Emacs-devel" Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:298844 Archived-At: Philip Kaludercic [2022-10-31 09:40:36] wrote: > there is at least one broken package on NonGNU ELPA > (color-theme-tangotango) that was added, then removed as dependencies > were missing, but it remained in the archive because it was added to the > archive-contents file. The following patch would make sure that any > package not listed in elpa-packages is also remove from > archive-contents: Thanks, but I don't think `elpaa--update-archive-contents` is the right place for that. This can be called N times for a given invocation of `elpaa-batch-make-all-packages`. Why not call a dedicated function from `elpaa-batch-make-all-packages` (i.e. alongside the call to `elpaa--publish-package-specs`)? > It might be a good idea to cache the interpretation of elpa-packages, so > I would also suggest the following: Not sure it's worth the trouble: the way the code is written, it should be called only once per Emacs session in the majority of cases, no? > 1. This does not remove any tarballs. It wouldn't be hard to do, but I > am not sure if there would be any unintended side effects of doing > so -- at least immediately. I think we should keep the old HTML page and tarballs. > 2. There are functioning packages on NonGNU ELPA like haskell-mode that > were also added to elpa-packages then removed, and still linger in > the archive without being updated. This would get rid of those too, > which might not be a good idea. Indeed, `haskell-mode` should be re-added to `elpa-packages` because IIRC it's still actively depended-upon (by GNU ELPA's `hcel`). Stefan