From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Yuan Fu <casouri@gmail.com>
Cc: emacs-devel <emacs-devel@gnu.org>
Subject: Re: Understanding end-of-defun
Date: Thu, 10 Nov 2022 17:49:24 -0500 [thread overview]
Message-ID: <jwvsfiqs9z2.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <FD1D5E33-2E10-45A2-8C84-CD80EF9D6AB1@gmail.com> (Yuan Fu's message of "Thu, 10 Nov 2022 14:35:15 -0800")
>> I haven't had a chance to try it out, but it looks good to me, tho
>> `beginning-of-defun-raw` doesn't mention anything about its return value
>> in the its docstring, so we may want to tweak that docstring (and
>> review its code to make sure that it indeed returns the value we need
>> in all cases, tho I suspect you've done so already).
>
> (Sorry for the delay) Yes, it returns nil in all cases. Pretty sure that’s
> the intent from the very beginning (looking at git logs). How about
> this patch?
LGTM, thank you!
Stefan
PS: I'm very happy to work with you: I just babble about and you
go and do the grunt work. Half kidding, obviously, but really,
I appreciate it, thank you.
next prev parent reply other threads:[~2022-11-10 22:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-26 2:22 Understanding end-of-defun Yuan Fu
2022-10-26 2:55 ` Stefan Monnier
2022-10-27 4:44 ` Yuan Fu
2022-10-27 15:25 ` Stefan Monnier
2022-11-10 22:35 ` Yuan Fu
2022-11-10 22:49 ` Stefan Monnier [this message]
2022-11-10 23:10 ` Yuan Fu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvsfiqs9z2.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.