From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Understanding end-of-defun Date: Thu, 10 Nov 2022 17:49:24 -0500 Message-ID: References: <46FF2036-9AB4-4C57-82B5-51260D287FC5@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33757"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel To: Yuan Fu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Nov 10 23:50:10 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1otGN8-0008ZG-DB for ged-emacs-devel@m.gmane-mx.org; Thu, 10 Nov 2022 23:50:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1otGMW-0003KP-UC; Thu, 10 Nov 2022 17:49:32 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otGMV-0003KG-Ew for emacs-devel@gnu.org; Thu, 10 Nov 2022 17:49:31 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1otGMT-00062G-Ji for emacs-devel@gnu.org; Thu, 10 Nov 2022 17:49:31 -0500 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 3B0A080073; Thu, 10 Nov 2022 17:49:27 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 9AC7A804C0; Thu, 10 Nov 2022 17:49:25 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1668120565; bh=VagHSiZC9rhf9T4P1wbFueAnJfbfqa+7xbsFKO7JfFA=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=IlzMzn7LX8KrcldqMY1OGTiSWUgbBtt8SrlDDkqyZyQzdZl+yhsfYKJ/BBoMPliS/ rGcijIG4tzyciNjyerZ5SAEyX4O7SeivcYB5fgjCtL5bUvUZ0hiPXooLfdDrYAAvTz W1KCN0XFCruIpsnnXobod/PvBiEm1hHmo2AyUwX+/Vqn2CZJaKl49l+S+HoU/bH+p2 11mKjV2nGyd89u7u/2nGEW/z6FmgORJwTDDVd9EmwPs1MsSjM75Wh0xh9P/YaP2ENA u8fcFa/IpPx4KXCWwVNI057/iEypYmcdmF4njfeIOjmQcH8uN1cbteFH0pxaV9qJLb 8TSiN0fturbag== Original-Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 777F4120112; Thu, 10 Nov 2022 17:49:25 -0500 (EST) In-Reply-To: (Yuan Fu's message of "Thu, 10 Nov 2022 14:35:15 -0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:299527 Archived-At: >> I haven't had a chance to try it out, but it looks good to me, tho >> `beginning-of-defun-raw` doesn't mention anything about its return value >> in the its docstring, so we may want to tweak that docstring (and >> review its code to make sure that it indeed returns the value we need >> in all cases, tho I suspect you've done so already). > > (Sorry for the delay) Yes, it returns nil in all cases. Pretty sure that= =E2=80=99s > the intent from the very beginning (looking at git logs). How about > this patch? LGTM, thank you! Stefan PS: I'm very happy to work with you: I just babble about and you go and do the grunt work. Half kidding, obviously, but really, I appreciate it, thank you.