From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Stephen Leake <stephen_leake@stephe-leake.org>
Cc: Fu Yuan <casouri@gmail.com>,
Theodor Thornhill <theo@thornhill.no>,
Lars Ingebrigtsen <larsi@gnus.org>,
emacs-devel <emacs-devel@gnu.org>
Subject: Re: Average-user-facing interface for tree-sitter
Date: Mon, 24 Oct 2022 17:07:15 -0400 [thread overview]
Message-ID: <jwvr0yx54g1.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <867d0pjg9y.fsf@stephe-leake.org> (Stephen Leake's message of "Mon, 24 Oct 2022 10:14:01 -0700")
>> I'm not comfortable with this notion of "backend", because each one of
>> those "backends" (elisp, treesit, eglot, ...) tends to support
>> a different set of features, so in practice, I'd expect that in the
>> common case many major modes will use a mix of those backends.
> Yes, one backend choice for each feature (most backends will provide
> more than one feature). There cannot be two backends for indent, but
> there can be different backends for indent and face.
Individual major modes can indeed offer more fine-grained control, but
I'm not convinced we want/need that complexity in the generic code.
Especially since existing "ELisp backends" (CC-mode, SMIE, and ad-hoc
ones) were not written with such piecemeal use in mind, so there's
a good chance we'd bump into more bugs.
I'd rather start small and later add such refined control if/when this
proves to be often necessary, at which point we'll know better what are
the pitfalls.
>> (add-hook 'treesit-mode-hook #'js--treesit-mode-hook nil t)
>> (js--treesit-mode-hook)
[...]
> Since js--treesit-mode-hook is provided by the major-mode, how is that
> better than simply including that code in js-mode, in a cond or cl-ecase
> on the desired backend for each feature?
We can't test directly from the major mode function because we don't
know yet if `treesit-mode` will be enabled. It'd have to be postponed
to `hack-local-variables` anyway.
[ IIUC you do that for ada-mode, right? ]
> Ah; js--treesit-mode-hook (I object to the name;
[ I object too, but I was in a hurry. Now that I have more time to
think about it, `js--post-treesit-setup` seems better. ]
> But what calls it to do the unset?
Minor mode hooks are called both when enabling and disabling the mode.
> I set the backend choices in my .emacs, and change them rarely (next
Toggling `treesit-mode` dynamically is expected to be rare, indeed.
But you might enable `treesit-mode` in a mode-hook and then want to
disable it in a child mode's hook.
>> We could try and help write this code by providing a helper function
>> that relies on some buffer-local var containing a list of vars to be set
>> (along with their values), a list of hooks to add (and remove), ...
>> so we don't need to duplicate the list into a "set" and an "unset"
>> branch like I had to do in the patch.
> That would be good.
>> Note that it's very similar to a "backend" function. But it's only
>> meant to choose between "treesit activated" and "treesit not
>> activated".
> We should also allow for eglot, wisi, and other future backends.
My hope is that for a given major mode we'll usually know which
functionality should better be offered via `treesit-mode` or via
`eglot-mode`. We'll definitely want to allow the user to refine this
choice, but I don't think we have enough experience yet with it to know
how important it is and what it should look like.
Stefan
next prev parent reply other threads:[~2022-10-24 21:07 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 6:11 Average-user-facing interface for tree-sitter Yuan Fu
2022-10-13 0:54 ` [SPAM UNSURE] " Stephen Leake
2022-10-13 6:32 ` Stephen Leake
2022-10-13 6:22 ` Lars Ingebrigtsen
2022-10-13 9:18 ` Robert Pluim
2022-10-13 9:21 ` Lars Ingebrigtsen
2022-10-13 9:32 ` Po Lu
2022-10-13 9:42 ` Robert Pluim
2022-10-13 12:31 ` Stefan Kangas
2022-10-13 9:57 ` Daniel Martín
2022-10-13 10:01 ` [SPAM UNSURE] " Stephen Leake
2022-10-13 14:32 ` Jostein Kjønigsen
2022-10-13 16:14 ` Eli Zaretskii
2022-10-13 17:27 ` Lars Ingebrigtsen
2022-10-13 19:44 ` Yuan Fu
2022-10-14 11:02 ` Lars Ingebrigtsen
2022-10-14 11:22 ` Stephen Leake
2022-10-14 20:10 ` Yuan Fu
2022-10-14 20:19 ` Yuan Fu
2022-10-14 20:49 ` Stefan Monnier
2022-10-14 22:51 ` Yuan Fu
2022-10-15 3:26 ` Stefan Monnier
2022-10-15 5:05 ` Yuan Fu
2022-10-17 9:07 ` Yuan Fu
2022-10-17 9:15 ` Lars Ingebrigtsen
2022-10-18 20:54 ` Yuan Fu
2022-10-18 21:48 ` Stefan Monnier
2022-10-18 22:06 ` Yuan Fu
2022-10-18 22:31 ` Stefan Monnier
2022-10-18 23:06 ` Yuan Fu
2022-10-19 2:52 ` Stefan Monnier
2022-10-19 3:48 ` [External] : " Drew Adams
2022-10-20 0:23 ` Yuan Fu
2022-10-19 5:35 ` Theodor Thornhill
2022-10-20 0:28 ` Yuan Fu
2022-10-20 7:44 ` Theodor Thornhill
2022-10-20 17:53 ` Stefan Monnier
2022-10-20 18:10 ` Theodor Thornhill
2022-10-20 18:11 ` Theodor Thornhill
2022-10-20 23:06 ` Yuan Fu
2022-10-21 22:10 ` Yuan Fu
2022-10-21 22:35 ` Stefan Monnier
2022-10-23 1:59 ` Fu Yuan
2022-10-23 4:59 ` Theodor Thornhill
2022-10-24 12:57 ` Stefan Monnier
2022-10-24 17:14 ` Stephen Leake
2022-10-24 21:07 ` Stefan Monnier [this message]
2022-10-24 20:51 ` Yuan Fu
2022-10-24 23:55 ` Stefan Monnier
2022-10-25 21:37 ` Yuan Fu
2022-10-25 22:49 ` Stefan Monnier
2022-10-27 1:56 ` Yuan Fu
2022-10-27 15:21 ` Stefan Monnier
2022-10-27 15:29 ` Dmitry Gutov
2022-10-28 8:02 ` Yuan Fu
2022-10-24 16:46 ` Stephen Leake
2022-10-18 20:49 ` Stefan Monnier
2022-10-18 20:58 ` Yuan Fu
2022-10-13 13:05 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2022-10-15 9:49 Payas Relekar
2022-10-16 11:03 ` Katevan Lomidze
2022-10-16 11:43 ` Eli Zaretskii
2022-10-15 13:03 Ketevan Lomidze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwvr0yx54g1.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=stephen_leake@stephe-leake.org \
--cc=theo@thornhill.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.