From: Yuan Fu <casouri@gmail.com>
To: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Lars Ingebrigtsen <larsi@gnus.org>, emacs-devel <emacs-devel@gnu.org>
Subject: Re: Average-user-facing interface for tree-sitter
Date: Tue, 18 Oct 2022 15:06:12 -0700 [thread overview]
Message-ID: <B33DC922-358B-4089-A0FB-59F16E965C59@gmail.com> (raw)
In-Reply-To: <jwvedv4g62s.fsf-monnier+emacs@gnu.org>
> On Oct 18, 2022, at 2:48 PM, Stefan Monnier <monnier@iro.umontreal.ca> wrote:
>
>> For separated major modes, they need to do a bit of a dance.
>
> I don't think we should even try and document what they should do:
> they're evil and we should spend our efforts merging them into one instead.
>
>> Besides switching to the new major mode, they need to add (mode
>> . new-mode) to major-mode-remap-alist if global-treesit-mode is on (so
>> next time we go straight to new-mode as long as global-treesit-mode is
>> on). They also need to add (mode . new-mode) to
>> treesit-remapped-major-mode-alist so global-treesit-mode can remove
>> these entries when it turns off.
>
> Too much magic, IMO. Let each case handle it manually, since I suspect
> that every case will be different and the best thing to do will vary (it
> depends on whether the two modes are still actively maintained, whether
> by the same authors or not, the relative age and popularity of the
> respective modes, …)
So we don’t do anything in global-treesit-mode? Ie,
(define-globalized-minor-mode global-treesit-mode treesit-mode
global-treesit-mode--turn-on
:version "29.1"
:group 'treesit
:predicate t
(when (not global-treesit-mode)
(dolist (map treesit-remapped-major-mode-alist)
(setq major-mode-remap-alist
(remove map major-mode-remap-alist)))))
to
(define-globalized-minor-mode global-treesit-mode treesit-mode
global-treesit-mode--turn-on
:version "29.1"
:group 'treesit
:predicate t
)
And remove treesit-remapped-major-mode-alist?
Yuan
next prev parent reply other threads:[~2022-10-18 22:06 UTC|newest]
Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 6:11 Average-user-facing interface for tree-sitter Yuan Fu
2022-10-13 0:54 ` [SPAM UNSURE] " Stephen Leake
2022-10-13 6:32 ` Stephen Leake
2022-10-13 6:22 ` Lars Ingebrigtsen
2022-10-13 9:18 ` Robert Pluim
2022-10-13 9:21 ` Lars Ingebrigtsen
2022-10-13 9:32 ` Po Lu
2022-10-13 9:42 ` Robert Pluim
2022-10-13 12:31 ` Stefan Kangas
2022-10-13 9:57 ` Daniel Martín
2022-10-13 10:01 ` [SPAM UNSURE] " Stephen Leake
2022-10-13 14:32 ` Jostein Kjønigsen
2022-10-13 16:14 ` Eli Zaretskii
2022-10-13 17:27 ` Lars Ingebrigtsen
2022-10-13 19:44 ` Yuan Fu
2022-10-14 11:02 ` Lars Ingebrigtsen
2022-10-14 11:22 ` Stephen Leake
2022-10-14 20:10 ` Yuan Fu
2022-10-14 20:19 ` Yuan Fu
2022-10-14 20:49 ` Stefan Monnier
2022-10-14 22:51 ` Yuan Fu
2022-10-15 3:26 ` Stefan Monnier
2022-10-15 5:05 ` Yuan Fu
2022-10-17 9:07 ` Yuan Fu
2022-10-17 9:15 ` Lars Ingebrigtsen
2022-10-18 20:54 ` Yuan Fu
2022-10-18 21:48 ` Stefan Monnier
2022-10-18 22:06 ` Yuan Fu [this message]
2022-10-18 22:31 ` Stefan Monnier
2022-10-18 23:06 ` Yuan Fu
2022-10-19 2:52 ` Stefan Monnier
2022-10-19 3:48 ` [External] : " Drew Adams
2022-10-20 0:23 ` Yuan Fu
2022-10-19 5:35 ` Theodor Thornhill
2022-10-20 0:28 ` Yuan Fu
2022-10-20 7:44 ` Theodor Thornhill
2022-10-20 17:53 ` Stefan Monnier
2022-10-20 18:10 ` Theodor Thornhill
2022-10-20 18:11 ` Theodor Thornhill
2022-10-20 23:06 ` Yuan Fu
2022-10-21 22:10 ` Yuan Fu
2022-10-21 22:35 ` Stefan Monnier
2022-10-23 1:59 ` Fu Yuan
2022-10-23 4:59 ` Theodor Thornhill
2022-10-24 12:57 ` Stefan Monnier
2022-10-24 17:14 ` Stephen Leake
2022-10-24 21:07 ` Stefan Monnier
2022-10-24 20:51 ` Yuan Fu
2022-10-24 23:55 ` Stefan Monnier
2022-10-25 21:37 ` Yuan Fu
2022-10-25 22:49 ` Stefan Monnier
2022-10-27 1:56 ` Yuan Fu
2022-10-27 15:21 ` Stefan Monnier
2022-10-27 15:29 ` Dmitry Gutov
2022-10-28 8:02 ` Yuan Fu
2022-10-24 16:46 ` Stephen Leake
2022-10-18 20:49 ` Stefan Monnier
2022-10-18 20:58 ` Yuan Fu
2022-10-13 13:05 ` Stefan Monnier
-- strict thread matches above, loose matches on Subject: below --
2022-10-15 9:49 Payas Relekar
2022-10-16 11:03 ` Katevan Lomidze
2022-10-16 11:43 ` Eli Zaretskii
2022-10-15 13:03 Ketevan Lomidze
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=B33DC922-358B-4089-A0FB-59F16E965C59@gmail.com \
--to=casouri@gmail.com \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=monnier@iro.umontreal.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.